fix: return structured JSON for malformed request bodies

[dymchenkko]

Description

JSON-body endpoints returned Axum's plain-text rejection when a request body
failed to deserialize (empty {}, missing field, invalid token address). Every
other error in this API is structured JSON, so clients that parse all responses
as JSON break. This makes that path consistent.

Reviewer notes: I added a generic Error schema (vs. per-endpoint enums) — open
to switching. Invalid syntax is 400, already documented per endpoint, so I
only documented the structured body on 422.

Changes

• Add a Json<T> extractor (api/extract.rs) wrapping axum::Json that, on a
  JsonRejection, returns the API's error("InvalidJson", …) with the
  rejection's status (422/400). Identical to axum::Json on success.
• Apply it to all JSON-body endpoints: post_quote, post_order,
  cancel_order, put_app_data, debug_simulation (cancel_orders /
  orders/by_uids parse raw bytes, unaffected).
• OpenAPI: add a generic Error schema, referenced from the affected 422s.

How to test

cargo test -p orderbook --lib api::extract — covers {} → 422 JSON (#4439),
invalid field value → 422 JSON (#4440), invalid syntax → 400 JSON.

Manual: POST /api/v1/quote with body {} → now 422 + application/json
{"errorType":"InvalidJson",…} instead of text/plain.

Related Issues

Fixes #4439
Fixes #4440

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[gemini-code-assist]

Code Review

This pull request introduces a custom Json extractor in crates/orderbook/src/api/extract.rs that wraps Axum's native extractor. When request deserialization fails, it returns a structured JSON error response containing errorType and description instead of plain text. The API endpoints in cancel_order.rs, debug_simulation.rs, post_order.rs, post_quote.rs, and put_app_data.rs have been updated to use this new extractor. Additionally, the OpenAPI specification (openapi.yml) has been updated to document the Error schema for 422 responses. No critical issues were found, and there is no feedback to provide.

[dymchenkko]

I have read the CLA Document and I hereby sign the CLA

[github-actions]

This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed.

[squadgazzz]

This is a breaking change for the public API. If any of the clients are parsing errors (which is most likely the case, including our front-end), this change would lead to errors on their end.

[squadgazzz]

@dymchenkko , thank you for your contribution! Please fix the PR description formatting. AI tends to generate in the wrong way.

[dymchenkko]

@squadgazzz Hey, thanks for the review! I want to make sure I understand the concern correctly. Before this change, when a request had malformed JSON, Axum returned a plain-text error instead of JSON. Every other error in these endpoints already returns {errorType, description} JSON, that's actually why #4439 and #4440 were filed as bugs. Could you point to a specific client that depends on the plain-text format? That would help me understand what exactly would break.