Remove unused code following some UCP removal#4444
Draft
jmg-duarte wants to merge 3 commits into
Draft
Conversation
Scoring uses auction-level native prices and settlement verification reads prices from on-chain calldata, so per-solution UCPs are dead weight. Drop them from the autopilot domain `Solution`, the `SolutionError::InvalidPrice` variant, and the `proposed_solutions` price columns (now written as empty arrays). The `/solve` wire format is preserved for rolling-deploy safety: - autopilot tolerates a missing `clearingPrices` (`#[serde(default)]`) - our driver still emits it from existing settlement data `clearingPrices` is marked `deprecated: true` in the driver and orderbook OpenAPI specs. A follow-up PR will remove the field, the deprecation log, and the empty DB columns.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the solution domain conversion logic by removing the ZeroScore and SolutionError types, along with the Score::try_new validation. As a result, into_domain methods now return domain solutions directly instead of wrapping them in a Result. This allows for the removal of error-handling logic, error metrics tracking, and partition-filtering in run_loop.rs and shadow.rs. No critical issues were found, and there is no feedback to provide.
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes a bunch of "dead code" — follow up to #4370 (comment)
Changes
How to test
Existing tests