Update CONTRIBUTING.md with new contribution guidelines#4503
Update CONTRIBUTING.md with new contribution guidelines#4503jmg-duarte wants to merge 2 commits into
Conversation
jmg-duarte
force-pushed
the
jmgd/contributing
branch
from
ca66b25 to
14fe369
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the contribution guidelines for CoW Protocol Services, detailing how external contributions are evaluated, issue labeling, PR size and scope, and the reward program. No critical issues found.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| - **`needs discussion`** — the default state for newly opened external issues. Maintainers have not yet decided whether the work is wanted, in scope, or correctly framed. Code work should not start yet. | ||
| - **`accepting contributions`** — scope is agreed and external contributors are welcome to pick this up. | ||
| - **`good first issue`** — small, well-scoped, and a good fit for someone new to the codebase. | ||
| - **`help wanted`** — explicitly tagged for community pickup, with a 100 DAI bounty attached (see [Reward program](https://www.notion.so/cownation/New-Contribution-Guidelines-3598da5f04ca80c6a9aef563a4865ac4#reward-program)). Applied manually by maintainers. |
There was a problem hiding this comment.
this page isn't public iiuc. Maybe we can publish this notion page, and then link to that.
| The team's review capacity is finite, and we'd rather set realistic expectations than leave you guessing. | ||
|
|
||
| - **Core-team work takes review priority.** External PRs are reviewed on a best-effort basis and may sit for several weeks. | ||
| - **Make sure CI is green before requesting review.** Please do not request review on a PR with failing checks. |
There was a problem hiding this comment.
First-time fork contributors need a maintainer to approve the workflow run before CI executes at all, so "CI green before requesting review" isn't something they can do on their own. Maybe add a note that maintainers will approve the run as part of triage. 👀 (or that atleast the basic CIs should pass before we run the heavier e2e tests. etc CIs)
| - Alternatives you've already considered. | ||
|
|
||
| If you believe your issue may be due to user error and not a problem in the library, consider instead posting a question on the [CoW Protocol Discord]. | ||
| > If you already have changes in mind, you may also open a *draft* PR for as a discussion starting point. |
There was a problem hiding this comment.
| > If you already have changes in mind, you may also open a *draft* PR for as a discussion starting point. | |
| > If you already have changes in mind, you may also open a *draft* PR as a discussion starting point. |
nit 🧐
| - Alternatives you've already considered. | ||
|
|
||
| If you believe your issue may be due to user error and not a problem in the library, consider instead posting a question on the [CoW Protocol Discord]. | ||
| > If you already have changes in mind, you may also open a *draft* PR for as a discussion starting point. |
There was a problem hiding this comment.
also, this might contradict the above rule, to not open a PR while the issue is in discussion phase.
3 participants
Description
Updates the contribution guidelines
Changes