feat(solana-indexer): PR 4 — Component structs (skeleton declarations)#4514
feat(solana-indexer): PR 4 — Component structs (skeleton declarations)#4514tilacog wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the skeleton structure for the Solana settlement indexer components, including the Ingester, Decoder, PartialEventWatchdog, and FinalizationWorker, along with necessary dependency updates and shared type definitions. Feedback on the changes suggests replacing the global static LATEST_CHAIN_SLOT with a shared Arc passed via constructors to avoid process-wide shared mutable state and potential race conditions during parallel testing.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| /// The sole writer is the ingester, on every slot-filter message. Anchors the | ||
| /// partial-event watchdog and the finalization worker. Cold start is zero; the | ||
| /// watchdog skips its comparison on the first tick. | ||
| pub static LATEST_CHAIN_SLOT: AtomicU64 = AtomicU64::new(0); |
There was a problem hiding this comment.
Using a global static AtomicU64 for LATEST_CHAIN_SLOT introduces shared mutable state across the entire process. This causes race conditions and flakiness when running unit/integration tests in parallel (Cargo's default behavior). It also prevents running multiple indexer instances in the same process.
Actionable Suggestion:
Remove the global static and instead pass an Arc<AtomicU64> (or a shared state struct) to the constructors of Ingester, Decoder, PartialEventWatchdog, and FinalizationWorker.
References
- Focus exclusively on identifying missing edge cases, potential race conditions, or logic that deviates from the PR's stated goals. (link)
Description
Adds the
indexer/module with skeleton declarations for the four components that will do the actual work of the indexer. Each struct declares its fields, a constructor, and doc comments describing what it will do; therunbodies areunimplemented!and the behavior lands in later PRs.The four components and their roles:
confirmedcommitment level. This worker re-checks them against the chain and promotes them tofinalized, or marks them rolled back if the transaction disappeared. It uses a cheap batched RPC call for recent rows and falls back to one-call-per-row lookups for rows old enough that the batched method no longer reports them.The field declarations also pin down how the components talk to each other: the ingester feeds the decoder over a bounded channel, while the decoder and the watchdog share a concurrent map with no message passing between them. That second decision reshaped the partial-event types, so
types/channel.rsbecametypes/shared.rs.Changes
indexer/ingester.rs: theIngesterstruct. Generic over the connection so unit tests can drive it with a mock (the trait-bound approach chosen in PR 3 instead of a third in-crate trait). Also declares the shared latest-chain-slot counter and the constants for reconnect backoff and channel capacity.indexer/decoder.rs: theDecoderstruct, holding the receiving end of the channel, the shared partial-event map, and the two program ids it filters for.indexer/watchdog.rs: thePartialEventWatchdogstruct, holding the store and its view of the shared partial-event map.indexer/finalization.rs: theFinalizationWorkerstruct, with module docs explaining the two promotion flows and the constants that bound them (finalization window, batch size, retention horizon).types/channel.rstotypes/shared.rsand reworked the partial-event types: instead of payloads sent over a channel, a partial event is now a key (slot + signature) and a value (whichever half arrived first) in the map shared by the decoder and the watchdog.yellowstone-grpc-clientto the workspace (source of the connection trait the ingester is generic over), plusdashmapand a few tokio features to the crate.How to test
cargo check -p solana-indexercargo clippy --locked -p solana-indexer --all-features --all-targets -- -D warningsNo unit tests are included: the structs declare shape only, and every
runbody isunimplemented!until the behavior PRs.