chore(deps): remove redundant Pygments pin from requirements.txt (closes #17)#18
chore(deps): remove redundant Pygments pin from requirements.txt (closes #17)#18
Conversation
#17) Application source has zero `pygments` references — confirmed via grep across all .py / .html / .js / .css. The explicit `Pygments==2.19.2` pin is residue from a stale pip-freeze snapshot. Notable: pytest 9.x lists pygments as a transitive `Requires:` (unlike pytest 8.x where it was optional/extra), so a fresh `pip install -r requirements.txt` will still install pygments via the pytest dep tree. Removing the explicit pin is therefore a "drop a redundant version pin" change, not a "remove an installed package" change. The benefit: future pytest bumps that bring a different pygments range no longer fight an unrelated explicit pin. Verification (clean venv built from this requirements.txt): - pip install -r requirements.txt: succeeds; pygments 2.20.0 pulled transitively by pytest, as expected. - pytest tests/ : 75/75 OK (was 75/75 before). - python app.py + curl /: HTTP 200.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe ChangesDependency Cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Problem
requirements.txtline 12 pinnedPygments==2.19.2. Application source has zeropygmentsreferences — verified viagrep -rin pygmentsacross all .py / .html / .js / .css. The line is residue from a stalepip freezesnapshot.Change
Drop the explicit pin.
Notable nuance worth flagging for the reviewer: pytest 9.x lists pygments as a transitive
Requires:(different from 8.x where it was optional / extras-only). So a freshpip install -r requirements.txtwill still install pygments — via pytest's dep tree, not ours. This is a "drop a redundant explicit version pin" change, not a "remove an installed package" change. The benefit is that future pytest bumps which need a different pygments range no longer fight an unrelated explicit pin in this file.Test plan
Built a clean venv from this requirements.txt and verified end-to-end:
pip install -r requirements.txtsucceedspytest tests/python app.py+curl /grepfinds zeropygmentsreferences in app sourceCloses #17.
Summary by CodeRabbit