Skip to content

Also test on MSVC with error-checked standard library #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MungoG wants to merge 1 commit into from
Closed

Also test on MSVC with error-checked standard library #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ jobs:
source-dir: boost-root
modules: corosio
toolset: ${{ matrix.b2-toolset }}
build-variant: ${{ matrix.build-type }}
build-variant: ${{ (matrix.compiler == 'msvc' && 'debug,release') || matrix.build-type }}
cxx: ${{ steps.setup-cpp.outputs.cxx || matrix.cxx || '' }}
Comment on lines 360 to 363
Copy link

@coderabbitai coderabbitai bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

alandefreitas/cpp-actions b2-workflow build-variant input format documentation

💡 Result:

In alandefreitas/cpp-actions → b2-workflow, the build-variant input is a single string naming the build variant. The action accepts CMake-style build types and maps them to B2, or you can pass a custom B2 variant name directly: Release → release, Debug → debug, RelWithDebInfo → release plus debug-symbols=on, and anything else is lowercased and used as the B2 variant. If build-variant is not set, it falls back to B2_BUILD_VARIANT, otherwise to build-type. [1]

Related: in B2 itself, the built-in variant feature’s standard values are debug and release. [2]

Sources
[1] B2 Workflow action docs (build-variant mapping and fallback rules) (alandefreitas.github.io)
[2] B2 manual (variant values) (bfgroup.xyz)

Citations:

The build-variant input expects a single variant string, not comma-separated values.

Line 362 passes debug,release to build-variant, but the alandefreitas/cpp-actions b2-workflow action accepts only a single variant per invocation. B2 will treat debug,release as a literal variant name (which does not exist) and the build will fail or skip the intended variants. To build both debug and release for MSVC, use a matrix strategy to invoke the workflow multiple times with separate build-variant values.

🤖 Prompt for AI Agents 
In @.github/workflows/ci.yml around lines 360 - 363, The workflow passes
"debug,release" into the build-variant input (via build-variant: ${{
(matrix.compiler == 'msvc' && 'debug,release') || matrix.build-type }}) but the
alandefreitas/cpp-actions b2-workflow expects a single variant string; change
the matrix to include a dedicated matrix key (e.g., matrix.build-variant) with
separate values "debug" and "release" for MSVC and update the action invocation
to use build-variant: ${{ matrix.build-variant }} (or map matrix.compiler to a
single build-variant per job) so each job runs one valid variant at a time.

cxxstd: ${{ matrix.cxxstd }}
address-model: ${{ (matrix.x86 && '32') || '64' }}
Expand Down
Loading