Skip to content

Initial C++20 module implementation #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sgerbino wants to merge 1 commit into from
Closed

Initial C++20 module implementation #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ option(BOOST_COROSIO_BUILD_BENCH "Build boost::corosio benchmarks" ${BOOST_COROS
option(BOOST_COROSIO_BUILD_EXAMPLES "Build boost::corosio examples" ${BOOST_COROSIO_IS_ROOT})
option(BOOST_COROSIO_BUILD_DOCS "Build boost::corosio documentation" OFF)
option(BOOST_COROSIO_MRDOCS_BUILD "Building for MrDocs documentation generation" OFF)
option(BOOST_COROSIO_USE_MODULES "Whether to build boost::corosio using C++20 modules or not" OFF)

# Check if environment variable BOOST_SRC_DIR is set
if (NOT DEFINED BOOST_SRC_DIR AND DEFINED ENV{BOOST_SRC_DIR})
Expand Down Expand Up @@ -185,6 +186,11 @@ add_library(boost_corosio ${BOOST_COROSIO_HEADERS} ${BOOST_COROSIO_SOURCES})
add_library(Boost::corosio ALIAS boost_corosio)
boost_corosio_setup_properties(boost_corosio)

if (BOOST_COROSIO_USE_MODULES)
target_sources(boost_corosio PUBLIC FILE_SET CXX_MODULES BASE_DIRS modules FILES modules/boost_corosio.cppm)
target_compile_definitions(boost_corosio PUBLIC BOOST_COROSIO_USE_MODULES)
endif()
Comment on lines +189 to +192
Copy link

@coderabbitai coderabbitai bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

CMake FILE_SET CXX_MODULES minimum version requirement

💡 Result:

Official (non-experimental) minimum CMake version for FILE_SET TYPE CXX_MODULES: 3.28 — the CXX_MODULES file-set type for target_sources(FILE_SET ...) was added in CMake 3.28. (cmake.org)

Earlier versions: CMake had experimental C++ modules support (gated by CMAKE_EXPERIMENTAL_CXX_MODULE_CMAKE_API) before 3.28, but the stable FILE_SET TYPE CXX_MODULES feature is 3.28+. (kitware.com)

Citations:

🏁 Script executed:

# Check the CMakeLists.txt file for minimum CMake version and the problematic code
head -20 CMakeLists.txt | cat -n

Repository: cppalliance/corosio

Length of output: 809

🏁 Script executed:

# Check lines 189-192 in CMakeLists.txt
sed -n '189,192p' CMakeLists.txt

Repository: cppalliance/corosio

Length of output: 293

🏁 Script executed:

# Also verify surrounding context to understand the structure
sed -n '16p' CMakeLists.txt

Repository: cppalliance/corosio

Length of output: 106

Add CMake version guard for C++20 modules support.

FILE_SET CXX_MODULES requires CMake 3.28+, but the project's minimum version is 3.16 (line 16). If a user enables BOOST_COROSIO_USE_MODULES with CMake < 3.28, they'll get a confusing error.

Proposed fix: add version check 
 if (BOOST_COROSIO_USE_MODULES)
+    if (CMAKE_VERSION VERSION_LESS "3.28")
+        message(FATAL_ERROR "BOOST_COROSIO_USE_MODULES requires CMake 3.28 or later")
+    endif()
     target_sources(boost_corosio PUBLIC FILE_SET CXX_MODULES BASE_DIRS modules FILES modules/boost_corosio.cppm)
     target_compile_definitions(boost_corosio PUBLIC BOOST_COROSIO_USE_MODULES)
 endif()
🤖 Prompt for AI Agents 
In `@CMakeLists.txt` around lines 189 - 192, The CMake snippet uses FILE_SET
CXX_MODULES which requires CMake 3.28+, so add a CMake version guard around the
BOOST_COROSIO_USE_MODULES branch: check CMAKE_VERSION and if it is less than
3.28 produce a clear fatal error or disable modules with a descriptive message
referencing BOOST_COROSIO_USE_MODULES, otherwise proceed to call
target_sources(boost_corosio PUBLIC FILE_SET CXX_MODULES BASE_DIRS modules FILES
modules/boost_corosio.cppm) and target_compile_definitions(boost_corosio PUBLIC
BOOST_COROSIO_USE_MODULES); ensure the error message and guard mention CMake
3.28+ and the option name so users get a clear instruction.


#-------------------------------------------------
#
# WolfSSL
Expand Down
5 changes: 5 additions & 0 deletions include/boost/corosio/acceptor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_ACCEPTOR_HPP
#define BOOST_COROSIO_ACCEPTOR_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/corosio/detail/except.hpp>
#include <boost/corosio/io_object.hpp>
Expand Down Expand Up @@ -286,3 +290,4 @@ class BOOST_COROSIO_DECL acceptor : public io_object
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/endpoint.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_ENDPOINT_HPP
#define BOOST_COROSIO_ENDPOINT_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/url/ipv4_address.hpp>
#include <boost/url/ipv6_address.hpp>
Expand Down Expand Up @@ -187,3 +191,4 @@ class endpoint
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/io_buffer_param.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_IO_BUFFER_PARAM_HPP
#define BOOST_COROSIO_IO_BUFFER_PARAM_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/capy/buffers.hpp>

Expand Down Expand Up @@ -383,3 +387,4 @@ class io_buffer_param
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/io_context.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_IO_CONTEXT_HPP
#define BOOST_COROSIO_IO_CONTEXT_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/corosio/detail/scheduler.hpp>
#include <boost/corosio/detail/unique_ptr.hpp>
Expand Down Expand Up @@ -433,3 +437,4 @@ get_executor() const noexcept ->
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/io_object.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_IO_OBJECT_HPP
#define BOOST_COROSIO_IO_OBJECT_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/capy/ex/execution_context.hpp>

Expand Down Expand Up @@ -70,3 +74,4 @@ class BOOST_COROSIO_DECL io_object
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/io_stream.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_IO_STREAM_HPP
#define BOOST_COROSIO_IO_STREAM_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/corosio/io_object.hpp>
#include <boost/capy/io_result.hpp>
Expand Down Expand Up @@ -247,3 +251,4 @@ class BOOST_COROSIO_DECL io_stream : public io_object
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/read.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_READ_HPP
#define BOOST_COROSIO_READ_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/corosio/io_stream.hpp>
#include <boost/capy/io_result.hpp>
Expand Down Expand Up @@ -218,3 +222,4 @@ read(io_stream& ios, std::string& s)
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/resolver.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_RESOLVER_HPP
#define BOOST_COROSIO_RESOLVER_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/corosio/detail/except.hpp>
#include <boost/corosio/io_object.hpp>
Expand Down Expand Up @@ -341,3 +345,4 @@ class BOOST_COROSIO_DECL resolver : public io_object
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/resolver_results.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_RESOLVER_RESULTS_HPP
#define BOOST_COROSIO_RESOLVER_RESULTS_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/corosio/endpoint.hpp>

Expand Down Expand Up @@ -206,3 +210,4 @@ class resolver_results
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/signal_set.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_SIGNAL_SET_HPP
#define BOOST_COROSIO_SIGNAL_SET_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/corosio/detail/except.hpp>
#include <boost/corosio/io_object.hpp>
Expand Down Expand Up @@ -355,3 +359,4 @@ class BOOST_COROSIO_DECL signal_set : public io_object
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/socket.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_SOCKET_HPP
#define BOOST_COROSIO_SOCKET_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/corosio/detail/except.hpp>
#include <boost/corosio/io_stream.hpp>
Expand Down Expand Up @@ -335,3 +339,4 @@ class BOOST_COROSIO_DECL socket : public io_stream
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/tcp_server.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_TCP_SERVER_HPP
#define BOOST_COROSIO_TCP_SERVER_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/corosio/acceptor.hpp>
#include <boost/corosio/socket.hpp>
Expand Down Expand Up @@ -335,3 +339,4 @@ class BOOST_COROSIO_DECL
} // boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/timer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_TIMER_HPP
#define BOOST_COROSIO_TIMER_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/corosio/detail/except.hpp>
#include <boost/corosio/io_object.hpp>
Expand Down Expand Up @@ -218,3 +222,4 @@ class BOOST_COROSIO_DECL timer : public io_object
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/tls/context.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_TLS_CONTEXT_HPP
#define BOOST_COROSIO_TLS_CONTEXT_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/system/result.hpp>

Expand Down Expand Up @@ -865,3 +869,4 @@ class BOOST_COROSIO_DECL context
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/tls/openssl_stream.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_TLS_OPENSSL_STREAM_HPP
#define BOOST_COROSIO_TLS_OPENSSL_STREAM_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/tls/context.hpp>
#include <boost/corosio/tls/tls_stream.hpp>

Expand Down Expand Up @@ -69,3 +73,4 @@ class BOOST_COROSIO_DECL openssl_stream : public tls_stream
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/tls/tls_stream.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_TLS_TLS_STREAM_HPP
#define BOOST_COROSIO_TLS_TLS_STREAM_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/capy/io_result.hpp>
#include <boost/corosio/io_stream.hpp>
Expand Down Expand Up @@ -263,3 +267,4 @@ class BOOST_COROSIO_DECL tls_stream : public io_stream
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/tls/wolfssl_stream.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_TLS_WOLFSSL_STREAM_HPP
#define BOOST_COROSIO_TLS_WOLFSSL_STREAM_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/corosio/tls/context.hpp>
#include <boost/corosio/tls/tls_stream.hpp>
Expand Down Expand Up @@ -71,3 +75,4 @@ class BOOST_COROSIO_DECL
} // namespace boost

#endif
#endif
5 changes: 5 additions & 0 deletions include/boost/corosio/write.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#ifndef BOOST_COROSIO_WRITE_HPP
#define BOOST_COROSIO_WRITE_HPP

#if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES)
import boost.corosio;
#else

#include <boost/corosio/detail/config.hpp>
#include <boost/corosio/io_stream.hpp>
#include <boost/capy/io_result.hpp>
Expand Down Expand Up @@ -99,3 +103,4 @@ write(io_stream& ios, ConstBufferSequence const& buffers)
} // namespace boost

#endif
#endif
48 changes: 48 additions & 0 deletions modules/boost_corosio.cppm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
module;

#include <boost/corosio.hpp>

Comment on lines +1 to +4
Copy link

@coderabbitai coderabbitai bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

git ls-files | head -20

Repository: cppalliance/corosio

Length of output: 421

🏁 Script executed:

# Find key files related to this review
fd -t f "corosio\.cppm|CMakeLists\.txt" | head -20

Repository: cppalliance/corosio

Length of output: 336

🏁 Script executed:

# Look for the module interface file and main header
find . -name "*boost_corosio*" -o -name "corosio.hpp" | grep -E "\.(cpp|cppm|h|hpp)$"

Repository: cppalliance/corosio

Length of output: 119

🏁 Script executed:

# Check the actual module interface file mentioned in the review
cat -n modules/boost_corosio.cppm 2>/dev/null || echo "File not found, searching for it..."

Repository: cppalliance/corosio

Length of output: 1450

🏁 Script executed:

# Search for include/boost/corosio structure
fd -t f . include/boost/corosio 2>/dev/null | head -20

Repository: cppalliance/corosio

Length of output: 829

🏁 Script executed:

# Read the main header file
cat -n include/boost/corosio.hpp | head -50

Repository: cppalliance/corosio

Length of output: 1276

🏁 Script executed:

# Read the config header which likely defines the macros
cat -n include/boost/corosio/detail/config.hpp

Repository: cppalliance/corosio

Length of output: 1651

🏁 Script executed:

# Search for BOOST_COROSIO_USE_MODULES and BOOST_COROSIO_SOURCE usage in headers
rg -n "BOOST_COROSIO_USE_MODULES|BOOST_COROSIO_SOURCE" include/

Repository: cppalliance/corosio

Length of output: 2330

🏁 Script executed:

# Check CMake configuration for the module unit
cat -n CMakeLists.txt | head -80

Repository: cppalliance/corosio

Length of output: 3406

🏁 Script executed:

# Look for how modules/boost_corosio.cppm is built in CMake
rg -n "boost_corosio\.cppm|corosio.*INTERFACE_UNITS|CXX_MODULE" CMakeLists.txt test/CMakeLists.txt

Repository: cppalliance/corosio

Length of output: 194

🏁 Script executed:

# Check what happens in one of the headers when the condition is true
cat -n include/boost/corosio/socket.hpp | head -40

Repository: cppalliance/corosio

Length of output: 1449

🏁 Script executed:

# Search for "import boost.corosio" in headers to confirm the recursive import concern
rg -n "import\s+boost\.corosio" include/

Repository: cppalliance/corosio

Length of output: 1189

🏁 Script executed:

# Check the CMakeLists around line 190 for context on how BOOST_COROSIO_SOURCE is defined for the module
sed -n '180,200p' CMakeLists.txt

Repository: cppalliance/corosio

Length of output: 860

🏁 Script executed:

# Look for target_compile_definitions for boost_corosio related to BOOST_COROSIO_SOURCE
rg -n "target_compile_definitions.*boost_corosio|BOOST_COROSIO_SOURCE" CMakeLists.txt

Repository: cppalliance/corosio

Length of output: 743

🏁 Script executed:

# Find the boost_corosio_setup_properties function to see if it applies BOOST_COROSIO_SOURCE
rg -n "boost_corosio_setup_properties" CMakeLists.txt -A 20

Repository: cppalliance/corosio

Length of output: 4487

🏁 Script executed:

# Get more context around line 159 where BOOST_COROSIO_SOURCE is defined
sed -n '150,170p' CMakeLists.txt

Repository: cppalliance/corosio

Length of output: 843

🏁 Script executed:

# Look for any place where BOOST_COROSIO_SOURCE is set for the module interface
rg -n "modules/boost_corosio\.cppm\|FILE_SET.*CXX_MODULES" CMakeLists.txt -B 5 -A 10

Repository: cppalliance/corosio

Length of output: 45

Add BOOST_COROSIO_SOURCE define to the module interface unit to prevent self-import.

When BOOST_COROSIO_USE_MODULES is enabled, all headers check #if !defined(BOOST_COROSIO_SOURCE) && defined(BOOST_COROSIO_USE_MODULES) and emit import boost.corosio; instead of includes. Since BOOST_COROSIO_SOURCE is defined as PRIVATE in the CMake target but the module interface unit may not reliably receive private definitions, the headers will attempt to import the module while it's being defined, causing a circular dependency. Define it locally in the module file:

Suggested fix 
 module;

+#define BOOST_COROSIO_SOURCE 1
 `#include` <boost/corosio.hpp>
+#undef BOOST_COROSIO_SOURCE
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
module;
#include <boost/corosio.hpp>
module;
`#define` BOOST_COROSIO_SOURCE 1
`#include` <boost/corosio.hpp>
`#undef` BOOST_COROSIO_SOURCE
🤖 Prompt for AI Agents 
In `@modules/boost_corosio.cppm` around lines 1 - 4, The module interface unit is
missing a local definition of BOOST_COROSIO_SOURCE so headers guarded by
BOOST_COROSIO_USE_MODULES try to import boost.corosio while the module is being
defined; add a local `#define` BOOST_COROSIO_SOURCE at the top of the module file
(before the `#include` <boost/corosio.hpp>) so the headers see the source
definition and use includes instead of emitting import boost.corosio, preventing
the self-import/circular dependency.

export module boost.corosio;

export namespace boost::corosio {

using corosio::acceptor;
using corosio::endpoint;
using corosio::io_buffer_param;
using corosio::io_context;
using corosio::io_object;
using corosio::io_stream;
using corosio::read;
using corosio::resolve_flags;
using corosio::resolver;
using corosio::resolver_entry;
using corosio::resolver_results;
using corosio::signal_set;
using corosio::socket;
using corosio::tcp_server;
using corosio::timer;
using corosio::write;
using corosio::operator|;
using corosio::operator&;
using corosio::operator&=;
using corosio::operator|=;

// I think this should be in tls
using corosio::tls_stream;
using corosio::openssl_stream;
using corosio::wolfssl_stream;
Comment on lines +30 to +33
Copy link

@coderabbitai coderabbitai bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove or clarify the inline note.
The // I think this should be in tls comment isn’t actionable and doesn’t explain the “why”; please remove it or replace with a concrete rationale/TODO. As per coding guidelines, ...

🧹 Suggested cleanup 
-// I think this should be in tls
-
 using corosio::tls_stream;
 using corosio::openssl_stream;
 using corosio::wolfssl_stream;
🤖 Prompt for AI Agents 
In `@modules/boost_corosio.cppm` around lines 30 - 33, Remove the non-actionable
inline comment "// I think this should be in tls" above the using declarations
for tls_stream, openssl_stream, and wolfssl_stream; either delete it or replace
it with a concrete note/TODO explaining why these aliases belong in a separate
tls module (e.g., "TODO: move these transport stream aliases to corosio::tls to
centralize TLS abstractions") so reviewers have a clear, actionable rationale
referencing tls_stream, openssl_stream, and wolfssl_stream.


namespace tls {
using corosio::tls::context;
using corosio::tls::file_format;
using corosio::tls::password_purpose;
using corosio::tls::revocation_policy;
using corosio::tls::role;
using corosio::tls::verify_mode;
using corosio::tls::version;
} // namespace tls


} // namespace boost::corosio


1 change: 1 addition & 0 deletions test/unit/io_context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#include <boost/corosio/io_context.hpp>

#include <boost/capy/concept/executor.hpp>
#include <boost/capy/coro.hpp>

#include <atomic>
#include <chrono>
Expand Down
2 changes: 2 additions & 0 deletions test/unit/resolver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
#include <boost/capy/cond.hpp>
#include <boost/capy/ex/run_async.hpp>
#include <boost/capy/task.hpp>
#include <boost/url/ipv4_address.hpp>
#include <boost/url/ipv6_address.hpp>

#include "test_suite.hpp"

Expand Down
Loading