fix: omit the synthesized initializer for default-constructed variables#1239
Open
gennaroprota wants to merge 1 commit into
Open
Conversation
Default-constructed variables (`T t;`) were rendered with a spurious initializer (`= t`). That's because Clang represents them with an implicit construction expression located at the variable name; so the extracted initializer text was the variable name itself. Therefore, skip the initializer when it is an implicit default construction. Closes issue #1238.
✨ Highlights
🧾 Changes by Scope
🔝 Top Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1239 +/- ##
========================================
Coverage 83.16% 83.16%
========================================
Files 35 35
Lines 3658 3658
Branches 843 843
========================================
Hits 3042 3042
Misses 409 409
Partials 207 207
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
An automated preview of the documentation is available at https://1239.mrdocs.prtest2.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-06-25 16:35:42 UTC |
gennaroprota
force-pushed
the
fix/omit_the_synthesized_initializer_for_default_constructed_variables
branch
2 times, most recently
from
a405d1a to
c0780e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default-constructed variables (
T t;) were rendered with a spurious initializer (= t). That's because Clang represents them with an implicit construction expression located at the variable name; so the extracted initializer text was the variable name itself.Therefore, skip the initializer when it is an implicit default construction.
Closes issue #1238.
Changes
Testing
A new golden test, with XML output, tests a handful of variable declarations.
Documentation
No documentation needed. This is a bug fix.