Open
Conversation
riasvdv
reviewed
Mar 31, 2026
|
|
||
| // If we're duplicating the entry type and the handle hasn't changed, find a unique one | ||
| if ($entryType->handle === ($originalEntryType->handle ?? null)) { | ||
| if ($saveAsNew && $entryType->handle === ($originalEntryType->handle ?? null)) { |
Contributor
There was a problem hiding this comment.
This is logic straight from 5.x: https://github.com/craftcms/cms/blob/5.x/src/controllers/EntryTypesController.php#L240
Do we need to change it there as well then?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placeholders were showing up in the
handlevalidator on entry types; once that was fixed, the error was cryptic (like "“2” is not a valid handle.”), which led me to the second patch.Checking
$saveAsNewseemed appropriate before trying to increment the handle; if someone chooses an existing handle, we probably shouldn't quietly swallow the collision.