[6.x] Harden GitHub actions with zizmor suggestions#18933
Open
riasvdv wants to merge 1 commit into
Open
Conversation
riasvdv
commented
May 20, 2026
Comment on lines
-15
to
+52
| - uses: ncipollo/release-action@v1 | ||
| with: | ||
| body: ${{ github.event.client_payload.notes }} | ||
| makeLatest: ${{ github.event.client_payload.latest }} | ||
| name: ${{ github.event.client_payload.version }} | ||
| prerelease: ${{ github.event.client_payload.prerelease }} | ||
| tag: ${{ github.event.client_payload.tag }} | ||
| - name: Create release | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| RELEASE_BODY: ${{ github.event.client_payload.notes }} | ||
| RELEASE_LATEST: ${{ github.event.client_payload.latest }} | ||
| RELEASE_NAME: ${{ github.event.client_payload.version }} | ||
| RELEASE_PRERELEASE: ${{ github.event.client_payload.prerelease }} | ||
| RELEASE_TAG: ${{ github.event.client_payload.tag }} | ||
| run: | | ||
| args=(release create "$RELEASE_TAG" --title "$RELEASE_NAME" --notes "$RELEASE_BODY") | ||
|
|
||
| if [[ "$RELEASE_PRERELEASE" == "true" ]]; then | ||
| args+=(--prerelease) | ||
| fi | ||
|
|
||
| case "$RELEASE_LATEST" in | ||
| true) | ||
| args+=(--latest) | ||
| ;; | ||
| false) | ||
| args+=(--latest=false) | ||
| ;; | ||
| legacy|"") | ||
| ;; | ||
| *) | ||
| echo "Unsupported latest value: $RELEASE_LATEST" >&2 | ||
| exit 1 | ||
| ;; | ||
| esac | ||
|
|
||
| gh "${args[@]}" |
Contributor
Author
There was a problem hiding this comment.
Not sure if this one is really worth it, though it's not terribly complicated
brandonkelly
requested review from
angrybrad
and removed request for
brandonkelly
| fi | ||
|
|
||
| git config user.name "github-actions[bot]" | ||
| git config user.email "41898282+github-actions[bot]@users.noreply.github.com" |
Contributor
There was a problem hiding this comment.
What’s the significance of this email/username?
Contributor
There was a problem hiding this comment.
Oh, bizarre, this is actually the mechanism for making @github-actions appear as the author… 😩
New question: if this is arbitrary, what benefit does it hold, vs. attributing to @shinybrad or another account/committer we “own.”
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zizmor