Skip to content

Shared#1040

Closed
henderkes wants to merge 25 commits intomainfrom
shared
Closed

Shared#1040
henderkes wants to merge 25 commits intomainfrom
shared

Conversation

@henderkes
Copy link
Collaborator

What does this PR do?

allows building and linking against shared libraries

TODO: building single libraries as shared, rather than all. E.g. to fix mssql issues with static openssl.

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@henderkes
Copy link
Collaborator Author

Let's drop this instead of adding this feature in a less-than ideal implementation in v2. V3 should have this build int with the easier config definition, spc-config would have to use --static flags depending on what a library wants to be linked as (static or shared).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant