Add macports support#1179
Merged
henderkes merged 4 commits intoJun 6, 2026
Merged
Conversation
Collaborator
|
Generally looks good, but I don't have a mac to check if macports has recent enough versions of tools. Are they quick to update like brew? |
crazywhalecc
requested changes
Jun 1, 2026
Contributor
Author
There was a period of quite some time where their PHP coverage lagged behind, but now they have a dedicated maintainer for PHP stuff so it is much more responsive. Currently at 8.5.4 for their PHP 8.5 support (though PHP itself is at 8.5.6). LLVM, as another example, is at 22.1.6, which matches the LLVM project itself. |
Collaborator
|
If they're at llvm 22 already I see no reason not to support macports. |
crazywhalecc
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR attempts to add support for operating in a MacPorts environment, if detected & if a Homebrew environment is not found.
(I do not use Homebrew at all, so I was unable to use spc until I addressed this in my local checkout.)
I have a concern that this change may not play nicely on a system that has Homebrew but does not have MacPorts, as I was only able to test the inverse of that. Perhaps I should add a fixPort method that detects if brew is installed (preferably in a non-circular way), and no-ops the macports check failure? Or will the lack of a fixPort method accomplish this implicitly?
Also, this is branched off of
v3, notfeat/pgo-v3. Unsure if that complicates things, but hopefully it isn't an issue.Checklist before merging
*.phpor*.yml, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:lint-config