Skip to content

Add macports support#1179

Merged
henderkes merged 4 commits into
crazywhalecc:v3from
beryllium:2026-05-28-add-macports-support
Jun 6, 2026
Merged

Add macports support#1179
henderkes merged 4 commits into
crazywhalecc:v3from
beryllium:2026-05-28-add-macports-support

Conversation

@beryllium

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR attempts to add support for operating in a MacPorts environment, if detected & if a Homebrew environment is not found.

(I do not use Homebrew at all, so I was unable to use spc until I addressed this in my local checkout.)

I have a concern that this change may not play nicely on a system that has Homebrew but does not have MacPorts, as I was only able to test the inverse of that. Perhaps I should add a fixPort method that detects if brew is installed (preferably in a non-circular way), and no-ops the macports check failure? Or will the lack of a fixPort method accomplish this implicitly?

Also, this is branched off of v3, not feat/pgo-v3. Unsure if that complicates things, but hopefully it isn't an issue.

Checklist before merging

  • If you modified *.php or *.yml, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:lint-config

@henderkes

Copy link
Copy Markdown
Collaborator

Generally looks good, but I don't have a mac to check if macports has recent enough versions of tools. Are they quick to update like brew?

Comment thread src/StaticPHP/Doctor/Item/MacOSToolCheck.php Outdated
@beryllium

Copy link
Copy Markdown
Contributor Author

Generally looks good, but I don't have a mac to check if macports has recent enough versions of tools. Are they quick to update like brew?

There was a period of quite some time where their PHP coverage lagged behind, but now they have a dedicated maintainer for PHP stuff so it is much more responsive. Currently at 8.5.4 for their PHP 8.5 support (though PHP itself is at 8.5.6).

LLVM, as another example, is at 22.1.6, which matches the LLVM project itself.

@henderkes

Copy link
Copy Markdown
Collaborator

If they're at llvm 22 already I see no reason not to support macports.

@henderkes henderkes merged commit 411ad7c into crazywhalecc:v3 Jun 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants