docs(contributing): fix version example to match integer schema#2
Open
abhicris wants to merge 1 commit into
Open
docs(contributing): fix version example to match integer schema#2abhicris wants to merge 1 commit into
abhicris wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Change the version-bump example in CONTRIBUTING.md from
`v1` → `v2`to`1` → `2`.Why
The scenario schema section immediately above states that
scenario.versionis an integer, but the immutability rule illustrates it with string literalsv1/v2. A contributor following the example literally would write a string value and fail schema validation. Removing thevprefix makes the example consistent with the type declared in the schema.Small, scoped fix from kcolbchain contrib-bot.