-
-
Notifications
You must be signed in to change notification settings - Fork 50
Pin GitHub Actions to commit SHAs #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThis pull request pins GitHub Actions dependencies across five workflow configuration files to specific commit SHAs, replacing generic version tags (v4, v2) with exact revisions. Each pinned action includes an inline comment documenting the previous version. Additionally, the build.yml workflow adds a Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/build.yml (1)
37-41:⚠️ Potential issue | 🟡 MinorInconsistent
softprops/action-gh-releaseversion across workflows.This file and
post-publish.ymlpin tov2.5.0(a06a81a...), whilebuild-linux.yml,build-mac.yml, andbuild-win.ymlpin tov2.4.1(6da8fa9...). All workflows should use the same version for consistency and to avoid subtle behavioral differences.Also,
draft: trueon Line 41 is a behavioral change beyond the stated scope of this PR (pinning SHAs). Releases created by this workflow will now be drafts instead of published. Please confirm this is intentional.
🧹 Nitpick comments (1)
.github/workflows/build-win.yml (1)
105-105: Missing version comment forskymatic/workflowsaction pin.All other pinned actions include a version comment (e.g.,
# v4.3.1), but this one only has#TODO: replace by azure signing. Consider adding the version or tag that SHA450e322...corresponds to, so future maintainers know what was pinned.Suggested improvement
- uses: skymatic/workflows/.github/actions/win-sign-action@450e322ff2214d0be0b079b63343c894f3ef735f `#TODO`: replace by azure signing + uses: skymatic/workflows/.github/actions/win-sign-action@450e322ff2214d0be0b079b63343c894f3ef735f # vX.Y.Z TODO: replace by azure signing
Pin all GitHub Actions and reusable workflows to immutable commit SHAs instead of version tags.
This improves supply-chain security.