Gracefully Handles "Bugged" Steam Market Skins#369
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the March 4/26 update, new skins listed on SCM after that time can't be inspected in-game. Currently, the public API server rejects new un-cached market calls, however this can cause their browser to throttle other successful float fetches since they are receiving multiple 4xx errors.
This PR handles the situation more gracefully by skipping skins in this "bugged" state from getting rendered/fetched, along with a banner signifying the count and why.
Closes CSF-1134
Note
Medium Risk
Changes market listing rendering and float-fetch behavior based on new Steam asset metadata; incorrect detection could hide float/sticker UI for legitimate skins or fail to warn users.
Overview
Prevents float/sticker UI and inspect-based network calls for a new class of Steam Market skins that are currently not inspectable, avoiding repeated 4xx errors and browser throttling.
Adds
isBuggedSkin()detection (usingunowned_contextidplus missingasset_propertiesfloat value metadata) and gates bothItemRowWrapperrendering and itsfetchFloat()flow on it. The market utility belt now counts these items on the page and shows a warning banner that updates asg_rgAssetschanges, andsteam.d.tsis extended to type the newasset_propertiesfield.Written by Cursor Bugbot for commit 6b9499f. This will update automatically on new commits. Configure here.