Feature/gtid gap log#419
Open
qiongtubao wants to merge 8 commits into
Open
Conversation
qiongtubao
force-pushed
the
feature/gtid_gap_log
branch
21 times, most recently
from
a0b8945 to
1e0c37b
Compare
qiongtubao
force-pushed
the
feature/gtid_gap_log
branch
9 times, most recently
from
0ed4344 to
709d831
Compare
qiongtubao
force-pushed
the
feature/gtid_gap_log
branch
from
709d831 to
b6895df
Compare
qiongtubao
force-pushed
the
feature/gtid_gap_log
branch
7 times, most recently
from
d999a0e to
941d566
Compare
…xt) and refactor saveGapLogFromGtidSet - readBacklogIterator stack-allocated with embedded mock client - querybuf reuse across gno iterations (no backlog re-read) - parseGtidCommand/parseMultiCommand take (argv, argc) and readBacklogIterator* respectively - saveGapLogFromGtidSet uses the iterator - parseCmdFromBacklog, cleanMockClient, resetMockClient removed - fix pre-existing typo: redisComamnd -> redisCommand in gtidOnKey
qiongtubao
force-pushed
the
feature/gtid_gap_log
branch
from
941d566 to
b5f82ef
Compare
randstring alpha range 48-122 includes '['(91) and ']'(93) which TCL interprets as command substitution, causing flaky failures when random client name happens to contain these chars.
qiongtubao
force-pushed
the
feature/gtid_gap_log
branch
from
13d4d19 to
1b6ee7d
Compare
added 3 commits
June 14, 2026 15:23
src/networking.c: In freeClient() defer-free path, use RS_UPDATE_DOWN instead of RS_UPDATE_NOP — when master mode is enabled via defer-free, the server state must reflect a real down transition, not a no-op. src/replication.c: Move disconnectSlaves() before shiftReplicationId() in replicationUnsetMaster(). Slaves must be disconnected before the replication ID changes so they can attempt partial resync with the new ID. deps/xredis-gtid: Update submodule pointer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.