IS-10102 Make "initialUrl" required on LWA bootstrap#117
Open
luisgoncalves wants to merge 1 commit intointegration/IS-5161/login-web-appfrom
Open
IS-10102 Make "initialUrl" required on LWA bootstrap#117luisgoncalves wants to merge 1 commit intointegration/IS-5161/login-web-appfrom
luisgoncalves wants to merge 1 commit intointegration/IS-5161/login-web-appfrom
Conversation
luisgoncalves
force-pushed
the
feature/dev/IS-10102-always-provide-initial-url
branch
from
6c46304 to
63a2f69
Compare
aleixsuau
approved these changes
Apr 7, 2026
| const initialUrl = configuration.initialUrl ?? window.location.href; | ||
| const initialStepLink: HaapiStepperLink = { | ||
| href: initialUrl, | ||
| href: configuration.initialUrl, |
There was a problem hiding this comment.
I think passing the initialUrl in the HaapiStepperConfig would be more standard and clear.
Contributor
Author
There was a problem hiding this comment.
This means that HaapiStepperConfig would become mandatory in the stepper, for all consumers. IIRC in the past we discussed similar things (for the HAAPI fetch configuration) and you argued in favor of not doing that.
If we do that, I think the whole configuration should be passed into the stepper, not just the initialUrl. That could also be OK, namely if we have a helper function like "read bootstrap config from window".
More thoughts?
markoweb
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.