Skip to content

IS-11176: Fix prettier config and apply formatting#121

Draft
aleixsuau wants to merge 1 commit intointegration/IS-5161/login-web-appfrom
feature/IS-11176/fix-linting-issues
Draft

IS-11176: Fix prettier config and apply formatting#121
aleixsuau wants to merge 1 commit intointegration/IS-5161/login-web-appfrom
feature/IS-11176/fix-linting-issues

Conversation

@aleixsuau
Copy link
Copy Markdown

@aleixsuau aleixsuau commented Apr 7, 2026

Summary

  • Added explicit tabWidth: 2 to .prettierrc to prevent indentation conflicts with parent configurations
  • Applied prettier formatting to 6 source files that were not conforming to the project config (indentation, trailing whitespace, line wrapping, missing newlines at EOF)

Test plan

  • Verify npx prettier --check passes on all LWA source files
  • Confirm CI build and lint pass

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Login Web App’s Prettier configuration to make formatting deterministic, then applies Prettier formatting across several files so they conform to the project’s style rules.

Changes:

  • Add explicit tabWidth: 2 to the Login Web App’s .prettierrc.
  • Apply Prettier-driven formatting/whitespace cleanup across CSS, TSX source, and tests.
  • Normalize file endings (eg, newline at EOF).

Reviewed changes

Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/login-web-app/src/shared/util/css/styles.css Prettier formatting applied to nested/extended CSS rules.
src/login-web-app/src/shared/feature/error-handling/default-error-fallback.tsx Prettier formatting of error fallback component.
src/login-web-app/src/haapi-stepper/feature/stepper/HaapiStepperErrorNotifier.tsx Minor whitespace cleanup.
src/login-web-app/src/haapi-stepper/feature/stepper/HaapiStepperErrorNotifier.spec.tsx Prettier wrapping/formatting in tests.
src/login-web-app/src/haapi-stepper/feature/stepper/HaapiStepper.tsx Prettier formatting (including JSX return compacting).
src/login-web-app/src/haapi-stepper/feature/stepper/HaapiStepper.spec.tsx Trailing whitespace removal.
src/login-web-app/package.json Formatting/newline normalization at EOF.
src/login-web-app/.prettierrc Add tabWidth: 2 to avoid config inheritance conflicts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.haapi-form-input {
@extend .field, .w100, mt2;
font-family: var(--type-regular);
@extend .field, .w100, mt2;
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this @extend list, mt2 is missing the . prefix, so it targets an element selector instead of the .mt2 utility class. This likely prevents the intended margin-top styles from being applied (note other @extend lists in this file use .mt2). Update it to .mt2 for consistency and correct behavior.

Suggested change
@extend .field, .w100, mt2;
@extend .field, .w100, .mt2;

Copilot uses AI. Check for mistakes.
@aleixsuau aleixsuau force-pushed the feature/IS-11176/fix-linting-issues branch 2 times, most recently from 7c71f2d to 156cc01 Compare April 7, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants