IS-11176: Fix prettier config and apply formatting#121
IS-11176: Fix prettier config and apply formatting#121aleixsuau wants to merge 1 commit intointegration/IS-5161/login-web-appfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Login Web App’s Prettier configuration to make formatting deterministic, then applies Prettier formatting across several files so they conform to the project’s style rules.
Changes:
- Add explicit
tabWidth: 2to the Login Web App’s.prettierrc. - Apply Prettier-driven formatting/whitespace cleanup across CSS, TSX source, and tests.
- Normalize file endings (eg, newline at EOF).
Reviewed changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/login-web-app/src/shared/util/css/styles.css | Prettier formatting applied to nested/extended CSS rules. |
| src/login-web-app/src/shared/feature/error-handling/default-error-fallback.tsx | Prettier formatting of error fallback component. |
| src/login-web-app/src/haapi-stepper/feature/stepper/HaapiStepperErrorNotifier.tsx | Minor whitespace cleanup. |
| src/login-web-app/src/haapi-stepper/feature/stepper/HaapiStepperErrorNotifier.spec.tsx | Prettier wrapping/formatting in tests. |
| src/login-web-app/src/haapi-stepper/feature/stepper/HaapiStepper.tsx | Prettier formatting (including JSX return compacting). |
| src/login-web-app/src/haapi-stepper/feature/stepper/HaapiStepper.spec.tsx | Trailing whitespace removal. |
| src/login-web-app/package.json | Formatting/newline normalization at EOF. |
| src/login-web-app/.prettierrc | Add tabWidth: 2 to avoid config inheritance conflicts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .haapi-form-input { | ||
| @extend .field, .w100, mt2; | ||
| font-family: var(--type-regular); | ||
| @extend .field, .w100, mt2; |
There was a problem hiding this comment.
In this @extend list, mt2 is missing the . prefix, so it targets an element selector instead of the .mt2 utility class. This likely prevents the intended margin-top styles from being applied (note other @extend lists in this file use .mt2). Update it to .mt2 for consistency and correct behavior.
| @extend .field, .w100, mt2; | |
| @extend .field, .w100, .mt2; |
7c71f2d to
156cc01
Compare
Summary
tabWidth: 2to.prettierrcto prevent indentation conflicts with parent configurationsTest plan
npx prettier --checkpasses on all LWA source files