Improve Bitmap clear time and cleanup go ranges.#5
Open
romanalexander wants to merge 2 commits intomainfrom
Open
Improve Bitmap clear time and cleanup go ranges.#5romanalexander wants to merge 2 commits intomainfrom
romanalexander wants to merge 2 commits intomainfrom
Conversation
…ch is much slower. `i := 0; i < len` = 149.8 ns/op `clear()` = 81 ns/op
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i := 0; i < len= 149.8 ns/opclear()= 81 ns/opNote
Medium Risk
Mostly mechanical loop cleanups and a faster
Clear, but bumpinggo.modto Go 1.22 can break builds for consumers or CI pinned to older Go versions.Overview
Speeds up
fixed.Bitmap.Clear()by switching to the built-inclear()and modernizes several hot-path loops inboringandfixedbitmap/array operations to use Go 1.22’sfor i := range niteration.Removes an unused
minhelper and updatesgo.modto require Go 1.22 (enabling the new range syntax).Written by Cursor Bugbot for commit eeaf0cf. This will update automatically on new commits. Configure here.