Skip to content

Upgrade dev tooling#190

Open
senechko wants to merge 5 commits into
mainfrom
codex/dev-tooling-upgrade
Open

Upgrade dev tooling#190
senechko wants to merge 5 commits into
mainfrom
codex/dev-tooling-upgrade

Conversation

@senechko
Copy link
Copy Markdown
Member

@senechko senechko commented May 19, 2026

Summary

  • upgrade TypeScript, Prettier, Husky, AVA, Sinon, and related dev dependencies
  • replace pretty-quick with lint-staged and modernize the Husky pre-commit hook
  • add type-aware ESLint with no-floating-promises, no-explicit-any, and consistent-type-imports
  • target ES2022 for Node 22 and remove redundant es2020.promise lib entry

Test Plan

  • npm run lint
  • npm run build
  • npm test

Note

Low Risk
Low risk: primarily developer-tooling/config changes (Husky, lint-staged, Prettier, ESLint) with only minor TypeScript type/import tweaks and no intended runtime behavior changes.

Overview
Upgrades local developer tooling by modernizing the Husky pre-commit hook to run check-version.ts and lint-staged (replacing pretty-quick), and expanding .prettierignore to skip generated/vendor artifacts.

Adds a new type-aware eslint.config.js (using @typescript-eslint) enforcing no-floating-promises, no-explicit-any, and consistent-type-imports with targeted overrides. Code changes are limited to TypeScript hygiene updates (type-only imports, narrower error type in Request, and a small conditional-spread tweak in TrackClient.addDevice).

Reviewed by Cursor Bugbot for commit 35cc7e5. Bugbot is set up for automated code reviews on this repo. Configure here.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 19, 2026

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 19, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
License policy violation: npm typescript

Location: Package overview

From: package-lock.jsonnpm/typescript@5.9.3

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/typescript@5.9.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
License policy violation: npm uri-js

Location: Package overview

From: package-lock.jsonnpm/eslint@10.4.0npm/uri-js@4.4.1

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/uri-js@4.4.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit df14988. Configure here.

Comment thread eslint.config.js
@senechko senechko force-pushed the codex/dev-tooling-upgrade branch from 97f0ec7 to f5926cf Compare May 19, 2026 21:20
@mike-engel
Copy link
Copy Markdown
Collaborator

#189 is also open. @senechko can you work with @kamiwaaidearu to choose one PR to champion?

@senechko senechko force-pushed the codex/dev-tooling-upgrade branch from d9ea9c4 to 35cc7e5 Compare May 22, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants