feat: add showScrollIndicators prop to inline in app message#593
Open
xavi-999 wants to merge 1 commit into
Open
feat: add showScrollIndicators prop to inline in app message#593xavi-999 wants to merge 1 commit into
xavi-999 wants to merge 1 commit into
Conversation
833e06e to
8beffd6
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 8beffd6. Configure here.
8beffd6 to
7b1aeae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Allow consumers to opt into hiding the WebView scroll indicators on the inline in-app message component. Defaults to true to preserve existing behavior; supports runtime toggling on both iOS and Android.
Problem
InlineInAppMessageViewrenders its animated content inside a nativeWKWebView(iOS) /WebView(Android). When the message content initially renders within the component's bounds the scroll indicators are visual noise — they flash on load and then disappear, making the component look off. Hiding them is the correct UX for typical inline-message usage.This was mainly replicated in Android. In smaller screen devices, sometimes, the scroll bar remains on screen indefinitely.
Screen.Recording.2026-05-19.at.17.17.16.mov
However, hiding them unconditionally in the SDK has two problems:
There was no prop to control this. The only path was to bake in a hardcoded value, which is not appropriate for a public SDK.
Solution
Add a
showScrollIndicators?: booleanprop toInlineInAppMessageView, defaulting totrue(native default, zero regression for existing consumers). Consumers setshowScrollIndicators={false}to opt into hiding.The prop is wired end-to-end:
1. Codegen spec (
src/specs/components/InlineMessageNativeComponent.ts)2. Public TS component (
src/components/InlineInAppMessageView.tsx)3. Android (
ReactInlineInAppMessageView.kt+InlineInAppMessageViewManager.kt)4. iOS (
ReactInlineMessageView.swift+.h+RCTInlineMessageNative.mm)All setters are declarative — they apply the value in both directions, so toggling at runtime works without remounting the component.
Note
Low Risk
Low risk: adds an optional UI-only prop with a default of
true, and the native changes are limited to toggling scroll indicator visibility without altering message loading or event semantics.Overview
Adds a new
showScrollIndicators?: booleanprop toInlineInAppMessageView(defaulting totrue) so consumers can hide WebView scroll bars for inline in-app messages.Wires the prop end-to-end via RN Codegen (
WithDefault<boolean, true>), updates the public TS props/API report, and applies the setting at runtime on Android by recursively enabling/disabling view scrollbars and on iOS by togglingWKWebView.scrollViewindicator visibility (including during load/size-change callbacks).Reviewed by Cursor Bugbot for commit 7b1aeae. Bugbot is set up for automated code reviews on this repo. Configure here.