fix: make source group filtering strict#1122
fix: make source group filtering strict#1122AnannyaMahajan wants to merge 3 commits intocybertec-postgresql:masterfrom
Conversation
|
Please 1. Fix failing tests 2. Add tests 3. Rewrite the PR description its too verbose |
Thanks for the review! I’ve fixed the failing tests, updated test coverage for strict group filtering, and rewritten the PR description to be more concise. |
Pull Request Test Coverage Report for Build 21074228430Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@AnannyaMahajan is this ready for review? |
sorry for delay I m still working on it |
|
overtaken in #1163 Sorry we are releasing v5 and need this fixed. |
Summary
Make source group filtering strict when groups are explicitly configured.
Changes
sources.groupsis set, only sources belonging to those groups are loadedTests
Notes
Tests now pass after updating expectations for strict group filtering.
Note: running tests locally requires generating web assets
(internal/webui → npm install && npm run build), which CI already does.