Gracefully handle lost network#91
Draft
scholzp wants to merge 3 commits intocyberus-technology:gardenlinuxfrom
Draft
Gracefully handle lost network#91scholzp wants to merge 3 commits intocyberus-technology:gardenlinuxfrom
scholzp wants to merge 3 commits intocyberus-technology:gardenlinuxfrom
Conversation
That way, when the connection between sender and receiver dies, both sides will time out and notice that something is wrong. On-behalf-of: SAP sebastian.eydam@sap.com Signed-off-by: Sebastian Eydam <sebastian.eydam@cyberus-technology.de>
On the receiver side, a live migration with status "aborted" does not return an error. Thus, management software will think that the live migration was successful. This is not expected behaviour. On-behalf-of: SAP sebastian.eydam@sap.com Signed-off-by: Sebastian Eydam <sebastian.eydam@cyberus-technology.de>
After introducing timeouts on sockets used for live migrations, live migations with mutliple TCP connections stopped working. This happens because the receiver side of the main connection does not get any messages while the VMs memory is being sent. Thus, we now send periodic keep alive messages when using multiple TCP connections. On-behalf-of: SAP sebastian.eydam@sap.com Signed-off-by: Sebastian Eydam <sebastian.eydam@cyberus-technology.de>
scholzp
requested review from
Coffeeri,
hertrste,
olivereanderson,
phip1611 and
tpressure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the receiver host cuts the network connection, the sender host will not proceed and hang. By introducing keep_alive messages that the sender receives from the receiver, the sender can decide when to cut the connection on proceed.
This is a fix for https://github.com/cobaltcore-dev/cobaltcore/issues/348