Skip to content

Conversation

@puzzledpolymath
Copy link
Contributor

@puzzledpolymath puzzledpolymath commented Jul 14, 2025

This is a chess move, thinking ahead when needing to support ULID's, in preparation for https://github.com/cycle/entity-behavior-identifier see 🎟️ cycle/entity-behavior-uuid#13

Needing this and cycle/entity-behavior#39 merged in order finish implementing ULID's within https://github.com/cycle/entity-behavior-identifier

🔍 What was changed

Not allot, just added annotations and column mapping for each driver.

📝 Checklist

  • How was this tested:
    • Unit tests added

@puzzledpolymath puzzledpolymath requested review from a team as code owners July 14, 2025 07:03
@puzzledpolymath puzzledpolymath changed the title Preparation for ulid dentifier Preparation for ULID identifier Jul 14, 2025
@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.41%. Comparing base (02808e1) to head (0f529c3).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     #233   +/-   ##
=========================================
  Coverage     95.41%   95.41%           
  Complexity     1891     1891           
=========================================
  Files           131      131           
  Lines          5273     5273           
=========================================
  Hits           5031     5031           
  Misses          242      242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roxblnfk roxblnfk added this to the 2.14.x milestone Jul 14, 2025
@roxblnfk roxblnfk added this to Cycle Jul 14, 2025
@github-project-automation github-project-automation bot moved this to In Progress in Cycle Jul 14, 2025
@roxblnfk roxblnfk merged commit f8b3a87 into 2.x Jul 14, 2025
31 of 32 checks passed
@roxblnfk roxblnfk deleted the preparation-for-ulid-dentifier branch July 14, 2025 08:23
@github-project-automation github-project-automation bot moved this from In Progress to Done in Cycle Jul 14, 2025
@roxblnfk roxblnfk changed the title Preparation for ULID identifier Add ULID column type Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants