Skip to content

Conversation

@roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Jul 14, 2025

Continue #230

In cases where the field size is unknown but we are comparing with a bool, we adjust the field size to 1.

@roxblnfk roxblnfk requested review from a team as code owners July 14, 2025 10:03
@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.42%. Comparing base (f8b3a87) to head (28128ac).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #234      +/-   ##
============================================
+ Coverage     95.41%   95.42%   +0.01%     
- Complexity     1891     1896       +5     
============================================
  Files           131      131              
  Lines          5273     5285      +12     
============================================
+ Hits           5031     5043      +12     
  Misses          242      242              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roxblnfk
Copy link
Member Author

@puzzledpolymath WDYT about this approach?

@puzzledpolymath
Copy link
Contributor

@roxblnfk While seemingly more complex, your solution is better.

I wasn't aware of this and completely bypassed the comment.

// since 8.0 database does not provide size for some columns

I've tested locally and you're changes have the same affect. You have my approval 🥇

Looking forward to this getting resolved finally and a 2.14 release out the door. I have some code partially written for ULID support and am keen to move onto Snowflake identifiers which will not be as straight-forward.

Copy link
Contributor

@puzzledpolymath puzzledpolymath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, appreciate the time and effort

@roxblnfk roxblnfk merged commit 82378ea into 2.x Jul 14, 2025
31 of 32 checks passed
@roxblnfk roxblnfk deleted the boolean-comparison branch July 14, 2025 11:33
@roxblnfk roxblnfk added this to the 2.14.x milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants