Skip to content

feat: 2026-grade modernization pass #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-oit merged 2 commits into from
May 8, 2026
+47 −218
Merged

feat: 2026-grade modernization pass #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be7f39c
feat: 2026-grade modernization pass
google-labs-jules[bot] May 8, 2026
cfc080c
Merge branch 'main' into feat-2026-modernization-pass-933027361867058…
d-oit May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
228 changes: 28 additions & 200 deletions .github/workflows/ci-and-labels.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,15 @@ export default tseslint.config(
...react.configs.flat['jsx-runtime'].rules,
...reactHooks.configs.recommended.rules,
...jsxA11y.flatConfigs.recommended.rules,
'react-refresh/only-export-components': ['warn', { allowConstantExport: true }],
'jsx-a11y/click-events-have-key-events': 'warn',
'jsx-a11y/no-static-element-interactions': 'warn',
'jsx-a11y/no-noninteractive-element-interactions': 'warn',
'jsx-a11y/interactive-supports-focus': 'warn',
'jsx-a11y/role-has-required-aria-props': 'warn',
'jsx-a11y/role-supports-aria-props': 'warn',
'jsx-a11y/no-autofocus': 'warn',
'react/no-unescaped-entities': 'warn',
'react-refresh/only-export-components': ['error', { allowConstantExport: true }],
'jsx-a11y/click-events-have-key-events': 'error',
'jsx-a11y/no-static-element-interactions': 'error',
'jsx-a11y/no-noninteractive-element-interactions': 'error',
'jsx-a11y/interactive-supports-focus': 'error',
'jsx-a11y/role-has-required-aria-props': 'error',
'jsx-a11y/role-supports-aria-props': 'error',
'jsx-a11y/no-autofocus': 'error',
'react/no-unescaped-entities': 'error',
},
settings: {
react: {
Expand Down Expand Up @@ -82,9 +82,9 @@ export default tseslint.config(
},
},
rules: {
'@typescript-eslint/no-unsafe-assignment': 'warn',
'@typescript-eslint/no-unsafe-call': 'warn',
'@typescript-eslint/no-unsafe-member-access': 'warn',
'@typescript-eslint/no-unsafe-assignment': 'error',
'@typescript-eslint/no-unsafe-call': 'error',
'@typescript-eslint/no-unsafe-member-access': 'error',
},
},

Expand Down
4 changes: 2 additions & 2 deletions src/components/ErrorBoundary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ class ErrorBoundary extends Component<Props, State> {
return { hasError: true, error };
}

componentDidCatch(error: Error, errorInfo: ErrorInfo): void {
override componentDidCatch(error: Error, errorInfo: ErrorInfo): void {
console.error('ErrorBoundary caught an error:', error, errorInfo);
}

render(): ReactNode {
override render(): ReactNode {
if (this.state.hasError) {
if (this.props.fallback) {
return this.props.fallback;
Expand Down
4 changes: 2 additions & 2 deletions src/lib/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
export class AppError extends Error {
constructor(
message: string,
override message: string,
public code: string,
public cause?: unknown
public override cause?: unknown
) {
super(message);
this.name = 'AppError';
Expand Down
5 changes: 3 additions & 2 deletions tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@
"lib": ["DOM", "DOM.Iterable", "ESNext"],
"allowJs": false,
"skipLibCheck": true,
"esModuleInterop": false,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"strict": true,
"noImplicitOverride": true,
Copy link
Copy Markdown
Contributor

@codacy-production codacy-production Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

Missing 'noUncheckedIndexedAccess: true' in compilerOptions, which was specified as a requirement in the PR description for this modernization pass.

"forceConsistentCasingInFileNames": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
Expand All @@ -19,7 +20,7 @@
"jsx": "react-jsx",
"baseUrl": ".",
"paths": {
"@/*": ["src/*"]
"@/*": ["./src/*"]
}
}
}
Loading