Skip to content

fix: exclude inaccessible posts from channel digest generation #3941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
capJavert merged 1 commit into from
Jun 11, 2026
Merged

fix: exclude inaccessible posts from channel digest generation #3941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
184 changes: 179 additions & 5 deletions __tests__/common/channelDigestGenerate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { ChannelDigest } from '../../src/entity/ChannelDigest';
import {
AGENTS_DIGEST_SOURCE,
Source,
SourceType,
UNKNOWN_SOURCE,
} from '../../src/entity/Source';
import { FreeformPost } from '../../src/entity/posts/FreeformPost';
Expand Down Expand Up @@ -50,14 +51,17 @@ const savePost = async ({
content,
createdAt,
channel,
...overrides
}: {
id: string;
sourceId?: string;
title: string;
content: string;
createdAt: Date;
channel: string;
}) =>
} & Partial<
Pick<FreeformPost, 'private' | 'visible' | 'banned' | 'showOnFeed'>
>) =>
con.getRepository(FreeformPost).save({
id,
shortId: id,
Expand All @@ -69,6 +73,7 @@ const savePost = async ({
contentMeta: {
channels: [channel],
},
...overrides,
});

describe('generateChannelDigest', () => {
Expand Down Expand Up @@ -385,7 +390,7 @@ describe('generateChannelDigest', () => {
);
});

it('should keep the unknown-source post id when no public SharePost exists', async () => {
it('should drop unknown-source posts when no public SharePost exists', async () => {
const now = new Date('2026-03-03T10:00:00.000Z');
let request: TopicalDigestRequest | undefined;

Expand Down Expand Up @@ -435,13 +440,182 @@ describe('generateChannelDigest', () => {
content: 'Orphan content',
createdAt: new Date('2026-03-03T09:00:00.000Z'),
channel: 'keep',
private: true,
});

const result = await generateChannelDigest({ con, definition, now });

expect(request?.posts.map((post) => post.postId)).toEqual(['orph-art']);
expect(result?.content).toContain(
'[Read more](http://localhost:5002/posts/orph-art)',
expect(request).toBeUndefined();
expect(result).toBeNull();
});

it('should drop unknown-source posts when the only share is private', async () => {
const now = new Date('2026-03-03T10:00:00.000Z');
let request: TopicalDigestRequest | undefined;

jest.spyOn(bragiClients, 'getBragiClient').mockImplementation(
(): ServiceClient<typeof Pipelines> => ({
instance: {
generateTopicalDigest: async (data: TopicalDigestRequest) => {
request = data;

return new TopicalDigest({
title: 'Private share digest',
tldr: 'Private share summary',
mainItems: [],
});
},
} as ServiceClient<typeof Pipelines>['instance'],
garmr: createGarmrMock(),
}),
);

await con
.getRepository(Source)
.save([
createSource(
UNKNOWN_SOURCE,
'Unknown',
'https://daily.dev/unknown.png',
),
createSource(
'squad-private',
'Private Squad',
'https://daily.dev/sq.png',
SourceType.Squad,
true,
),
createSource(
'private-share-digest-source',
'Digest',
'https://daily.dev/d.png',
),
]);
const definition = await saveDefinition({
key: 'private-share-test',
sourceId: 'private-share-digest-source',
channel: 'private-share',
frequency: 'daily',
});
await savePost({
id: 'unk-priv',
sourceId: UNKNOWN_SOURCE,
title: 'Unknown article',
content: 'Article content',
createdAt: new Date('2026-03-03T09:00:00.000Z'),
channel: 'private-share',
private: true,
});
await con.getRepository(SharePost).save({
id: 'sh-priv',
shortId: 'sh-priv',
sourceId: 'squad-private',
type: PostType.Share,
sharedPostId: 'unk-priv',
visible: true,
private: true,
showOnFeed: true,
deleted: false,
banned: false,
createdAt: new Date('2026-03-03T09:30:00.000Z'),
});

const result = await generateChannelDigest({ con, definition, now });

expect(request).toBeUndefined();
expect(result).toBeNull();
});

it('should exclude private, banned, invisible and hidden posts from candidates', async () => {
const now = new Date('2026-03-03T10:00:00.000Z');
let request: TopicalDigestRequest | undefined;

jest.spyOn(bragiClients, 'getBragiClient').mockImplementation(
(): ServiceClient<typeof Pipelines> => ({
instance: {
generateTopicalDigest: async (data: TopicalDigestRequest) => {
request = data;

return new TopicalDigest({
title: 'Filtered digest',
tldr: 'Filtered summary',
mainItems: [
new TopicalDigestItem({
title: 'Filtered item',
body: 'Filtered body',
postIds: ['acc-post'],
}),
],
});
},
} as ServiceClient<typeof Pipelines>['instance'],
garmr: createGarmrMock(),
}),
);

await con
.getRepository(Source)
.save([
createSource(
'content-source',
'Content',
'https://daily.dev/content.png',
),
createSource(
'filtered-digest-source',
'Digest',
'https://daily.dev/d.png',
),
]);
const definition = await saveDefinition({
key: 'filtered-test',
sourceId: 'filtered-digest-source',
channel: 'filtered',
frequency: 'daily',
});
const createdAt = new Date('2026-03-03T09:00:00.000Z');
await savePost({
id: 'acc-post',
title: 'Accessible post',
content: 'Accessible content',
createdAt,
channel: 'filtered',
});
await savePost({
id: 'priv-post',
title: 'Private post',
content: 'Private content',
createdAt,
channel: 'filtered',
private: true,
});
await savePost({
id: 'ban-post',
title: 'Banned post',
content: 'Banned content',
createdAt,
channel: 'filtered',
banned: true,
});
await savePost({
id: 'inv-post',
title: 'Invisible post',
content: 'Invisible content',
createdAt,
channel: 'filtered',
visible: false,
});
await savePost({
id: 'hid-post',
title: 'Hidden post',
content: 'Hidden content',
createdAt,
channel: 'filtered',
showOnFeed: false,
});

await generateChannelDigest({ con, definition, now });

expect(request?.posts.map((post) => post.postId)).toEqual(['acc-post']);
});
});
26 changes: 24 additions & 2 deletions src/common/channelDigest/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
TopicalDigestPost,
TopicalDigestRequest,
} from '@dailydotdev/schema';
import { Brackets } from 'typeorm';
import type { DataSource } from 'typeorm';
import type { ChannelDigest } from '../../entity/ChannelDigest';
import { generateShortId } from '../../ids';
Expand Down Expand Up @@ -113,6 +114,20 @@ const findDigestPosts = async ({
.addSelect('post.content', 'content')
.where('post.createdAt >= :from', { from })
.andWhere('post.deleted = false')
.andWhere('post.visible = true')
.andWhere('post.banned = false')
.andWhere('post."showOnFeed" = true')
.andWhere(
new Brackets((builder) => {
builder
.where('post.private = false')
// Keep private unknown-source posts as candidates so they can be
// remapped to an accessible public share post below.
.orWhere('post."sourceId" = :unknownSource', {
unknownSource: UNKNOWN_SOURCE,
});
}),
)
.andWhere(`(post."contentMeta"->'channels') ? :channel`, {
channel,
})
Expand Down Expand Up @@ -154,8 +169,15 @@ const remapUnknownSourcePostIds = async ({
const remapped: DigestPostRow[] = [];

for (const post of posts) {
const fallbackId =
post.sourceId === UNKNOWN_SOURCE ? fallbacks.get(post.id) : undefined;
const isUnknownSource = post.sourceId === UNKNOWN_SOURCE;
const fallbackId = isUnknownSource ? fallbacks.get(post.id) : undefined;

if (isUnknownSource && !fallbackId) {
// Unknown-source posts are private, without a public share fallback
// the digest would link to a post readers can not access.
continue;
}

const id = fallbackId ?? post.id;

if (seen.has(id)) {
Expand Down
Loading