Vendor extensions#126
Open
yousifBilal wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
One of the pain points that I face with using standard compliant parsing, is that many vendor tools allow syntax that is not part of the standard. I have implemented the grammar extensions with feature gates, since probably people will either use parsing with the extensions or without. Additionally, If people are only interested in standard grammar, they don't see the extension grammar nodes.
Since this pull request is somewhat large, You can review it by going through each commit; they are self-contained:
Commit 82c792d: Add vendor extension: nested begins in GenerateBlock
As the title indicates, relaxes rules regarding generate blocks. Example:
Introducing feature flags breaks the build script of sv-parser-syntaxtree, so I had to move the
AnyNodeandRefNodeenums to pre build time. This requires adding variants manually to these enums whenever a new node is added.Commit 3c577c3: Fix relax empty queue syntax
The empty queue is accepted as
'{}. You can see examples in sv-testsCommit 1e7f5dc: Allow consecutive unary operators
All formal verification tools allow consecutive unary operators like
property property_1; (a == b |-> !|c); endpropertyCommit 591f3f9: Allow brace without apostrophes for arrays
Some tools allow associate arrays without leading apostrophe like: