Skip to content

Conversation

@ceJce
Copy link

@ceJce ceJce commented Jan 14, 2026

Changed so that auto-configured values (without specified values) are set to itself instead of 1.

From issue 14317

isless=islesss

instead of
isless=1

@danmar
Copy link
Owner

danmar commented Jan 14, 2026

I would expect that we test this in some way.

@chrchr-github
Copy link
Collaborator

This needs to be fixed in simplecpp, probably here:
const std::string rhs(eq==std::string::npos ? std::string("1") : macrostr.substr(eq+1));
https://github.com/danmar/simplecpp/blob/6d45cd7bf7f12878ed99a5dcf5ee410ef6492a4a/simplecpp.cpp#L3343

@danmar
Copy link
Owner

danmar commented Jan 14, 2026

This needs to be fixed in simplecpp, probably here:

I am not sure. Then what happens if user executes cppcheck like this:

cppcheck -DX test.c

-DX should work the same as -DX=1 imho.

@ceJce ceJce force-pushed the fix14317_syntax_error branch from 05b5536 to eb9075c Compare January 14, 2026 15:08
@sonarqubecloud
Copy link

@ceJce ceJce marked this pull request as draft January 14, 2026 15:12
@danmar
Copy link
Owner

danmar commented Jan 14, 2026

hmm.. the fix seems to work when I test it quickly. but is in wrong repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants