Fix #14533, #14536 FN stlcstrConcat, stlcstrAssignment, stlcstrConstructor#8261
Open
chrchr-github wants to merge 9 commits intodanmar:mainfrom
Open
Fix #14533, #14536 FN stlcstrConcat, stlcstrAssignment, stlcstrConstructor#8261chrchr-github wants to merge 9 commits intodanmar:mainfrom
chrchr-github wants to merge 9 commits intodanmar:mainfrom
Conversation
danmar
reviewed
Feb 25, 2026
chrchr-github
changed the title
danmar
reviewed
Feb 25, 2026
chrchr-github
changed the title
|
chrchr-github
commented
Feb 26, 2026
| { | ||
| const QString filter(tr("Library files (*.cfg)")); | ||
| const QString path = Path::getPathFromFilename(mFileName.toStdString()).c_str(); | ||
| const QString path = QString::fromStdString(Path::getPathFromFilename(mFileName.toStdString())); |
Collaborator
Author
There was a problem hiding this comment.
We have stdStringLike strings in qt.cfg, sfml.cfg and wxwidgets.cfg, which all have conversion functions to/from std::string. So it should be OK to warn if the types don't match. I guess converting e.g. a QString to a wxString is pretty rare.
danmar
reviewed
Feb 26, 2026
| if (!cstr) | ||
| return false; | ||
| const Token* strTok = (cstr == tok->astOperand1()) ? tok->astOperand2() : tok->astOperand1(); | ||
| return strTok->valueType() && strTok->valueType()->container && strTok->valueType()->container->stdStringLike; |
Owner
There was a problem hiding this comment.
gcc does not complain about this weird code:
#include <string>
int main() {
std::string s;
auto a = + s.c_str();
return 0;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.