fixed #13659 - set proper line for file-level unmatchedSuppression#8266
Merged
firewave merged 1 commit intodanmar:mainfrom Feb 26, 2026
Merged
fixed #13659 - set proper line for file-level unmatchedSuppression#8266firewave merged 1 commit intodanmar:mainfrom
unmatchedSuppression#8266firewave merged 1 commit intodanmar:mainfrom
Conversation
|
danmar
reviewed
Feb 26, 2026
| std::list<::ErrorMessage::FileLocation> callStack; | ||
| if (!s.fileName.empty()) { | ||
| callStack.emplace_back(s.fileName, s.lineNumber, 0); | ||
| callStack.emplace_back(s.fileName, s.lineNumber == -1 ? 0 : s.lineNumber, 0); // TODO: get rid of s.lineNumber == -1 hack |
Owner
There was a problem hiding this comment.
It feels like you should tweak NO_LINE and what reportErr does with the NO_LINE value instead. there are warnings that don't have a line number and we should have a consistent output.
danmar
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.