store all errors in AnalyzerInformation even if suppressed#8267
Draft
firewave wants to merge 1 commit intodanmar:mainfrom
Draft
store all errors in AnalyzerInformation even if suppressed#8267firewave wants to merge 1 commit intodanmar:mainfrom
AnalyzerInformation even if suppressed#8267firewave wants to merge 1 commit intodanmar:mainfrom
Conversation
|
Collaborator
Author
|
Still needs a ticket. This highlights that the builddir needs to be utilized differently. It needs to store all errors regardless if they are being suppressed. If cached results are found it will "replay" them and thus properly feed the suppressions (hopefully) allowing us to get rid of the hack introduced in #8173. This already feeds some cases where that hack was not sufficient. This might not play well with CTU in some cases but if that is the case we are currently lacking the test coverage. I am approaching this in a test-driven way and this gets us a step closer to be able to merge #7079. |
firewave
changed the title
AnalyzerInfo even if suppressedAnalyzerInformation even if suppressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.