feature - implement RFC 021 generator foundations (#38)#47
Draft
dannymeijer wants to merge 1 commit into
Draft
Conversation
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the first RFC 021 generator/table-valued function foundation on top of the RFC020 branch. This slice introduces registry-backed generator applications for the explode family, keeps generators distinct from scalar expressions and aggregate measures, and lowers them through the current Substrait
ExtensionSingleRelrelation-extension boundary.Refs #38.
Stack order: merge #44, then #45, then #46, then this PR.
Type of change
docs/rfcs/*)Area(s)
Key details
generate(...)plusexplode(...),explode_outer(...),posexplode(...), andposexplode_outer(...)helper applications with required output aliases. The existing zero-argDataSet.explode()remains as a compatibility marker.GeneratorApplication, generator registry metadata, PrismGeneratenodes, generator-aware output-column inference, relation-extension lowering, and unique relation extension URN anchors when multiple extension relations appear in one plan.inline,inline_outer,stack, portable table-valuedflatten, query-block syntax, and DataFusion table-valued execution remain future work.Testing / verification
make ci(ormake fmt-check,make build,make test)Manual verification notes:
incan test tests/test_generator_functions.incnincan test src/generator_builders.incnincan test src/functions/generatorsincan test tests/test_prism.incnincan test tests/test_dataset.incnincan test tests/test_function_registry.incnincan test tests/test_substrait_plan.incnmake fmtmake fmt-checkmake test-stylemake registry-metadatamake buildmake testmake smoke-consumermake pre-commitDocs impact
If docs updated:
docs/language/reference/functions/generators.md,docs/language/reference/dataset_methods.md,docs/rfcs/021_generator_table_functions.md,docs/release_notes/v0_1.mdChecklist