placement: optimize bitmap range checks with byte-level skipping

[Copilot]

tgt_isset_range, dom_isset_range, and dom_isset_2ranges iterated every index one-by-one even when large runs of the bitmap were fully set. Since the bitmap is a uint8_t array, a single byte covers 8 indices — checking bits[index >> 3] == 0xFF lets us skip the entire byte unconditionally.

Changes

• Single unified loop replaces the prior three-phase (leading/middle/trailing) approach. Alignment pre-work is unnecessary: if bits[index >> 3] == 0xFF, every bit in that byte is set regardless of where index sits within it, so index = (index | 7) + 1 safely jumps to the next byte.
• dom_isset_2ranges uses (bits1[b] | bits2[b]) == 0xFF as the skip predicate — OR of both bytes being all-ones means isclr(bits1,i) && isclr(bits2,i) is impossible for any i in that byte.

for (index = start; index <= end; /* index advanced in body */) {
    if (bits[index >> 3] == 0xFF) {
        index = (index | 7) + 1;
        continue;
    }
    if (!is_excluded_comp(...) && isclr(bits, index))
        return false;
    ++index;
}

Steps for the author:

• Commit message follows the guidelines.
• Appropriate Features or Test-tag pragmas were used.
• Appropriate Functional Test Stages were run.
• At least two positive code reviews including at least one code owner from each category referenced in the PR.
• Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

• Gatekeeper requested (daos-gatekeeper added as a reviewer).

Original prompt

Create a new interactive placement debugging utility pl_debug under src/placement/tests in daos-stack/daos.

Background/goal:
We want a developer tool similar in spirit to jump_map_dist.c but interactive. The tool should construct an in-memory pool map and jump placement map from user-specified topology parameters and allow interactive commands to change pool component status and generate/print object layouts.

Repository/branch:

• Repo: daos-stack/daos
• Base branch: master

Binary/tool:

• Name: pl_debug
• Location: src/placement/tests/pl_debug.c (or .cc if needed)
• Ensure it is built by the DAOS build system (CMake) in the src/placement/tests area.

Command-line options:

• -n <number>: number of nodes
• -r <number>: number of ranks per node
• -t <number>: number of targets per rank
  After parsing options, create:
• an in-memory pool map with a hierarchy such that node is the fault domain
• ranks distributed with r ranks per node across n nodes
• t targets per rank
• a jump placement map based on that pool map

Interactive shell:
After setup, enter interactive mode (read-eval-print loop). Support commands:

1. obj_class <str_name>

   • Convert str_name to an object class ID as defined in src/include/daos_obj_class.h
   • Set the selected class in a global/current variable used by gen_layout
   • Accept either enum-style names (e.g. OC_EC_8P3GX) and also allow numeric input (optional but preferred)
   • Print the resolved class ID and name.

2. gen_layout id=<number>

   • Use <number> as oid.lo
   • Use currently-selected obj class and current pool map/placement map to generate an object layout
   • Print the layout in a human-readable form including (at minimum):
     • shard index
     • target id
     • rank
     • target index
     • fseq
     • rebuilding flag if present
   • Include group/stripe group delineation if applicable.

3. set_down rank=<number>|node=<number>

   • Set specified rank or node and all targets under it to status DOWN
   • Use ds_pool_map_tgts_update() to apply target state change to the pool map (as requested)

4. set_downout rank=<number>|node=<number>

   • Set status to DOWNOUT (again via ds_pool_map_tgts_update())

5. set_up rank=<number>|node=<number>

   • Set status to UP (via ds_pool_map_tgts_update())

6. set_upin rank=<number>|node=<number>

   • Set status to UPIN (via ds_pool_map_tgts_update())

General shell behavior:

• Provide help and quit/exit commands.
• Validate inputs with clear error messages.
• After any pool map update, ensure placement map sees the updated pool map (recreate placement map or refresh as needed).

Implementation notes:

• Follow existing patterns in src/placement/tests and/or jump_map_dist.c.
• Keep the tool self-contained; it should not require a running DAOS system.
• Use DAOS internal APIs to create pool map and jump placement map.
• Choose/initialize reasonable defaults for OID hi fields, object metadata, etc.

Testing:

• Add minimal smoke-test instructions in comments or documentation.
• Ensure it compiles on master.

Deliverables:

• New source file(s) under src/placement/tests
• CMake updates to build pl_debug
• Any small helper changes required for compilation (avoid large refactors)

This pull request was created from Copilot chat.

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[daosbuild3]

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/2/execution/node/305/log

[daosbuild3]

Test stage Build on EL 9.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/2/execution/node/339/log

[daosbuild3]

Test stage Build on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/2/execution/node/374/log

[daosbuild3]

Test stage Build on Leap 15.5 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/2/execution/node/409/log

[daosbuild3]

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/3/execution/node/304/log

[daosbuild3]

Test stage Build on EL 9.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/3/execution/node/338/log

[daosbuild3]

Test stage Build on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/3/execution/node/373/log

[daosbuild3]

Test stage Build on Leap 15.5 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/3/execution/node/408/log

[daosbuild3]

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/4/execution/node/305/log

[daosbuild3]

Test stage Build on EL 9.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/4/execution/node/339/log

[daosbuild3]

Test stage Build on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/4/execution/node/374/log

[daosbuild3]

Test stage Build on Leap 15.5 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/4/execution/node/409/log

[daosbuild3]

Test stage NLT on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/19/execution/node/684/log

[daosbuild3]

Test stage Fault injection testing on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/23/execution/node/1000/log

[daosbuild3]

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/24/execution/node/304/log

[daosbuild3]

Test stage Build on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/24/execution/node/320/log

[daosbuild3]

Test stage Build on Leap 15.5 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/24/execution/node/328/log

[daosbuild3]

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/25/execution/node/304/log

[daosbuild3]

Test stage Build on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/25/execution/node/320/log

[daosbuild3]

Test stage Build on Leap 15.5 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/25/execution/node/328/log

[daosbuild3]

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/26/execution/node/304/log

[daosbuild3]

Test stage Build on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/26/execution/node/320/log

[daosbuild3]

Test stage Build on Leap 15.5 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17623/26/execution/node/328/log