Skip to content

DAOS-18645 ddb: fix incompatible linked library#17634

Open
knard38 wants to merge 2 commits intomasterfrom
ckochhof/fix/master/daos-18645/patch-001
Open

DAOS-18645 ddb: fix incompatible linked library#17634
knard38 wants to merge 2 commits intomasterfrom
ckochhof/fix/master/daos-18645/patch-001

Conversation

@knard38
Copy link
Contributor

@knard38 knard38 commented Mar 3, 2026

Description

ddb was linked against the two incompatible libraries libdaos_common.so and libdaos_common_pmem.so.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Ticket title is 'ddb is linked with incompatible DAOS libraries'
Status is 'In Review'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-18645

@knard38 knard38 marked this pull request as ready for review March 3, 2026 15:51
@knard38 knard38 requested review from a team as code owners March 3, 2026 15:51
@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Mar 3, 2026
@daosbuild3
Copy link
Collaborator

tanabarr
tanabarr previously approved these changes Mar 3, 2026
Nasf-Fan
Nasf-Fan previously approved these changes Mar 4, 2026
ddb was linked against the two incompatible libraries libdaos_common.so
and libdaos_common_pmem.so.

features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@knard38 knard38 force-pushed the ckochhof/fix/master/daos-18645/patch-001 branch from 9e62b0b to 75bda78 Compare March 4, 2026 06:13
@knard38
Copy link
Contributor Author

knard38 commented Mar 4, 2026

My apologies for the rebase and force push: it was mandatory to fix the corruption of master resulting from the GitHub instabilities.

@knard38 knard38 self-assigned this Mar 4, 2026
Fix reviewers comments:
-  Fix copyright

features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@knard38 knard38 dismissed stale reviews from tanabarr and Nasf-Fan via 9315000 March 4, 2026 13:05
@knard38 knard38 requested review from Nasf-Fan and tanabarr and removed request for tanabarr March 4, 2026 13:16
@daosbuild3
Copy link
Collaborator

@daosbuild3
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17634/7/testReport/

@knard38 knard38 added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Mar 6, 2026
@knard38
Copy link
Contributor Author

knard38 commented Mar 6, 2026

The only functional test failure snapshot_aggregation.py is not related to this PR. It is an ENOMEN issue with pool creation:

image

Thus, I have added label forced-landing

@daos-stack/daos-gatekeeper please could you lend this PR.

@knard38 knard38 requested a review from a team March 6, 2026 07:41
@daltonbohning
Copy link
Contributor

The only functional test failure snapshot_aggregation.py is not related to this PR. It is an ENOMEN issue with pool creation:

The test failure does appear unrelated, but I do not see an existing ticket, nor has it failed in the past week of daily regression runs. Are we sure this PR isn't somehow affecting it?

@knard38
Copy link
Contributor Author

knard38 commented Mar 6, 2026

The only functional test failure snapshot_aggregation.py is not related to this PR. It is an ENOMEN issue with pool creation:

The test failure does appear unrelated, but I do not see an existing ticket, nor has it failed in the past week of daily regression runs. Are we sure this PR isn't somehow affecting it?

I am pretty sure it is unrelated as this PR should only change the C shared library linking of ddb. However, I had some surprise in the past and thus I am going to restart the hardware test Jenkins step and look more in depth of the logs. If needed, I will create a JIRA ticket.

@knard38
Copy link
Contributor Author

knard38 commented Mar 7, 2026

The only functional test failure snapshot_aggregation.py is not related to this PR. It is an ENOMEN issue with pool creation:

The test failure does appear unrelated, but I do not see an existing ticket, nor has it failed in the past week of daily regression runs. Are we sure this PR isn't somehow affecting it?

I am pretty sure it is unrelated as this PR should only change the C shared library linking of ddb. However, I had some surprise in the past and thus I am going to restart the hardware test Jenkins step and look more in depth of the logs. If needed, I will create a JIRA ticket.

As expected, the functional test passed the second time (i.e. build 8).
My first investigation on the log of the build 7 shows that the issue is occurring in the engine code which is not impacted by this PR.

2026/03/05 13:54:36.838437 hdr-112 DAOS[572291/-1/0] mgmt ERR  src/mgmt/mgmt_common.c:223 ds_mgmt_tgt_preallocate() a004e428: failed to allocate vos file /mnt/daos0/NEWBORNS/a004e428-4cae-4d95-bfb7-be38cb0af18d/vos-5 with size: 10015997952: DER_NOMEM(-1009): 'Out of memory'
2026/03/05 13:54:36.846256 hdr-112 DAOS[572291/-1/0] mgmt ERR  src/mgmt/mgmt_common.c:223 ds_mgmt_tgt_preallocate() a004e428: failed to allocate vos file /mnt/daos0/NEWBORNS/a004e428-4cae-4d95-bfb7-be38cb0af18d/vos-2 with size: 10015997952: DER_NOMEM(-1009): 'Out of memory'
2026/03/05 13:54:36.851975 hdr-112 DAOS[572291/-1/0] mgmt ERR  src/mgmt/mgmt_common.c:223 ds_mgmt_tgt_preallocate() a004e428: failed to allocate vos file /mnt/daos0/NEWBORNS/a004e428-4cae-4d95-bfb7-be38cb0af18d/vos-6 with size: 10015997952: DER_NOMEM(-1009): 'Out of memory'
2026/03/05 13:54:36.862717 hdr-112 DAOS[572291/-1/0] mgmt ERR  src/mgmt/mgmt_common.c:223 ds_mgmt_tgt_preallocate() a004e428: failed to allocate vos file /mnt/daos0/NEWBORNS/a004e428-4cae-4d95-bfb7-be38cb0af18d/vos-3 with size: 10015997952: DER_NOMEM(-1009): 'Out of memory'
2026/03/05 13:54:36.865854 hdr-112 DAOS[572291/-1/0] mgmt ERR  src/mgmt/mgmt_common.c:223 ds_mgmt_tgt_preallocate() a004e428: failed to allocate vos file /mnt/daos0/NEWBORNS/a004e428-4cae-4d95-bfb7-be38cb0af18d/vos-0 with size: 10015997952: DER_NOMEM(-1009): 'Out of memory'
2026/03/05 13:54:36.869797 hdr-112 DAOS[572291/-1/0] mgmt ERR  src/mgmt/mgmt_common.c:223 ds_mgmt_tgt_preallocate() a004e428: failed to allocate vos file /mnt/daos0/NEWBORNS/a004e428-4cae-4d95-bfb7-be38cb0af18d/vos-1 with size: 10015997952: DER_NOMEM(-1009): 'Out of memory'
2026/03/05 13:54:36.874792 hdr-112 DAOS[572291/-1/0] mgmt ERR  src/mgmt/mgmt_common.c:223 ds_mgmt_tgt_preallocate() a004e428: failed to allocate vos file /mnt/daos0/NEWBORNS/a004e428-4cae-4d95-bfb7-be38cb0af18d/vos-7 with size: 10015997952: DER_NOMEM(-1009): 'Out of memory'
2026/03/05 13:54:36.957028 hdr-112 DAOS[572291/-1/0] mgmt ERR  src/mgmt/mgmt_common.c:223 ds_mgmt_tgt_preallocate() a004e428: failed to allocate vos file /mnt/daos0/NEWBORNS/a004e428-4cae-4d95-bfb7-be38cb0af18d/vos-4 with size: 10015997952: DER_NOMEM(-1009): 'Out of memory'

Thus this PR can be landed safely from my understanding.

Before landing this PR, could you wait that I have finished my investigation and create a ticket.
Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)

Development

Successfully merging this pull request may close these issues.

7 participants