DAOS-17946 doc: update space_rb default in comment#17644
Open
daltonbohning wants to merge 1 commit intomasterfrom
Open
DAOS-17946 doc: update space_rb default in comment#17644daltonbohning wants to merge 1 commit intomasterfrom
daltonbohning wants to merge 1 commit intomasterfrom
Conversation
Per #17032, default space_rb is now 5%. Doc-only: true Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
daltonbohning
commented
Mar 4, 2026
| /** | ||
| * Reserve space ratio: amount of space to be reserved on each target | ||
| * for rebuild purpose. default = 0%. | ||
| * for rebuild purpose. default = 5%. |
Contributor
Author
There was a problem hiding this comment.
I wonder if we should actually just remove the default in this comment so it doesn't get out of sync. And most other props in this file don't mention default values either.
|
Ticket title is 'Document better Defaults for DAOS (RF3, cell size, etc)' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #17032, default space_rb is now 5%.
Doc-only: true
Steps for the author:
After all prior steps are complete: