DAOS-18487 rebuild: asynchronous discard handler (#17621)#17646
DAOS-18487 rebuild: asynchronous discard handler (#17621)#17646gnailzenh wants to merge 1 commit intorelease/2.6from
Conversation
- pool_discard doesn't wait for completion of discard anymore, instead if create discard ULT and return immediately. - Fix a rance and make sure no concurrent discards, so rebuild system doesn't start multiple discard ULTs even if there is resend discard. Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
|
Errors are Unable to load ticket data |
|
Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17646/1/execution/node/404/log |
|
Test stage Build RPM on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17646/1/execution/node/367/log |
|
Test stage Build RPM on EL 8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17646/1/execution/node/368/log |
|
Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17646/1/execution/node/359/log |
| rc = ds_iv_ns_reint_prep(pool->sp_iv_ns); /* cleanup IV cache */ | ||
| ABT_mutex_unlock(pool->sp_mutex); | ||
|
|
||
| D_INFO(DF_UUID " discard is scheduled\n", DP_UUID(arg->pool_uuid)); |
There was a problem hiding this comment.
might want to save that D_INFO for when rc == 0 case?
| if (tls->mpt_fini) | ||
| D_GOTO(free_notls, rc); | ||
|
|
||
| ABT_mutex_lock(pool->sp_mutex); |
There was a problem hiding this comment.
why check pool->sp_discard_status inside the loop, since it will only ever become a nonzero value at the same time that pool->sp_discarding will be set to 0, at least from what it looks like in ds_pool_tgt_discard_ult() ?
3 participants
Steps for the author:
After all prior steps are complete: