DAOS-18945 container: bypass space check in flags tx update (#18365)#18490
Draft
kccain wants to merge 1 commit into
Draft
DAOS-18945 container: bypass space check in flags tx update (#18365)#18490kccain wants to merge 1 commit into
kccain wants to merge 1 commit into
Conversation
When a pool's RDB has reached capacity usage to the point where further rdb_tx_update() can return -DER_NOSPACE, a container destroy operation (though epxecting to free RDB space) may itself encounter -DER_NOSPACE. It is possibly due to cont_destroy() first performing rdb_tx_update() before a second phase cont_destroy_post() performs (space-relieving) operations rdb_tx_delete() and rdb_tx_destroy_kvs(). With this change, convert the container_flags update in cont_destroy() to a "critical" tx update, bypassing RDB free space checks. Features: container ObjectMetadata Signed-off-by: Kenneth Cain <kenneth.cain@hpe.com>
kccain
added
the
clean-cherry-pick
|
Ticket title is 'server/metadata.py:ObjectMetadata.test_metadata_fillup_svc_ops_disabled - failed to destroy container: DER_NOSPACE' |
github-actions
Bot
added
the
priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a pool's RDB has reached capacity usage to the point where further rdb_tx_update() can return -DER_NOSPACE, a container destroy operation (though epxecting to free RDB space) may itself encounter -DER_NOSPACE. It is possibly due to cont_destroy() first performing rdb_tx_update() before a second phase cont_destroy_post() performs (space-relieving) operations rdb_tx_delete() and rdb_tx_destroy_kvs().
With this change, convert the container_flags update in cont_destroy() to a "critical" tx update, bypassing RDB free space checks.
Features: container ObjectMetadata
Steps for the author:
After all prior steps are complete: