CS-1982 | CS-2170: Added ACH endpoints by kc-sabal · Pull Request #18 · dapi-co/dapi-java

kc-sabal · 2023-01-12T07:31:02Z

No description provided.

jonmmyers

Looks good 👍

asmsh · 2023-02-10T08:49:50Z

src/main/java/co/dapi/ACH.java

+        return resp;
+    }
+
+    public static class CreatePull {


Rename to PullTransfer.

asmsh · 2023-02-10T08:51:56Z

src/main/java/co/dapi/response/CreatePullResponse.java

@@ -0,0 +1,11 @@
+package co.dapi.response;
+
+public class CreatePullResponse extends BaseResponse {


Rename to CreateACHPullResponse.

asmsh · 2023-02-10T08:54:14Z

src/main/java/co/dapi/types/PullTransfer.java

@@ -0,0 +1,26 @@
+package co.dapi.types;
+
+public class PullTransfer {


Rename to ACHPullTransferInfo.

asmsh · 2023-02-10T08:56:07Z

src/main/java/co/dapi/response/GetPullResponse.java

+
+import java.util.Optional;
+
+public class GetPullResponse extends BaseResponse {


Rename to GetACHPullResponse.

asmsh · 2023-02-10T08:59:44Z

src/main/java/co/dapi/DapiApp.java

+    /**
+     * createPull talks to the CreatePull endpoint of Dapi, with this {@link DapiApp}'s appSecret,
+     * to continue a previous operation that required to provide some userInputs.
+     *
+     * @param transfer    the transfer details that we want to initiate.
+     * @param accessToken retrieved from the ExchangeToken process.
+     * @param userSecret  retrieved from the user login.
+     * @param operationID retrieved from the previous call's response.
+     * @param userInputs  built from the previous call's response, and the required user input.
+     * @return an {@link CreatePullResponse}.
+     * @throws IOException in case of trouble happened while executing the request or reading the response.
+     */
+    public CreatePullResponse createPull(ACH.CreatePull transfer, String accessToken, String userSecret, String operationID, UserInput[] userInputs) throws IOException {
+        return this.ach.createPull(transfer, accessToken, userSecret, operationID, userInputs);
+    }
+
+
+    /**
+     * getPull talks to the GetPull endpoint of Dapi, with this {@link DapiApp}'s appSecret,
+     * to continue a previous operation that required to provide some userInputs.
+     *
+     * @param accessToken retrieved from the ExchangeToken process.
+     * @param userSecret  retrieved from the user login.
+     * @param operationID OperationID of the createPull request
+     * @param userInputs  built from the previous call's response, and the required user input.
+     * @return an {@link GetPullResponse}.
+     * @throws IOException in case of trouble happened while executing the request or reading the response.
+     */
+    public GetPullResponse getPull(String accessToken, String userSecret, String operationID, UserInput[] userInputs) throws IOException {
+        return this.ach.getPull(accessToken, userSecret, operationID, userInputs);
+    }


Each method should an extra overloaded version, one that doesn't accept the operationID and userInputs, for the case of createPull, but for getPull is should not accept only userInputs.

asmsh · 2023-02-10T08:59:55Z

src/main/java/co/dapi/DapiApp.java

+     * @return an {@link CreatePullResponse}.
+     * @throws IOException in case of trouble happened while executing the request or reading the response.
+     */
+    public CreatePullResponse createPull(ACH.CreatePull transfer, String accessToken, String userSecret, String operationID, UserInput[] userInputs) throws IOException {


Rename to createACHPull.

asmsh · 2023-02-10T09:00:08Z

src/main/java/co/dapi/DapiApp.java

+     * @return an {@link GetPullResponse}.
+     * @throws IOException in case of trouble happened while executing the request or reading the response.
+     */
+    public GetPullResponse getPull(String accessToken, String userSecret, String operationID, UserInput[] userInputs) throws IOException {


Rename to getACHPull.

CS-1982: Added ACH pull

f5d218f

kc-sabal requested a review from jonmmyers January 12, 2023 07:31

jonmmyers approved these changes Jan 19, 2023

View reviewed changes

kc-sabal added 2 commits January 25, 2023 13:57

CS-1982: Fixed create pull request class

a07c51e

CS-2170: Added ACH getPull

c69f630

kc-sabal changed the title ~~CS-1982: Added ACH pull~~ CS-1982 | CS-2170: Added ACH endpoints Jan 25, 2023

kc-sabal requested a review from jonmmyers January 25, 2023 12:25

jonmmyers approved these changes Jan 30, 2023

View reviewed changes

jonmmyers requested a review from asmsh February 1, 2023 05:37

CS-2170: formatting

d34e467

asmsh suggested changes Feb 10, 2023

View reviewed changes

kc-sabal self-assigned this Feb 10, 2023

kc-sabal added 4 commits February 11, 2023 17:12

CS-2170: Renamed class to pullTransfer

b38f593

CS-2170: Renamed ACH method names in DapiApp

b06d400

CS-2170: Renamed response and types

e377868

CS-2170: Added overloaded ach methods

c78847c

kc-sabal requested a review from asmsh February 13, 2023 08:00

		@@ -0,0 +1,11 @@
		package co.dapi.response;

		public class CreatePullResponse extends BaseResponse {

		@@ -0,0 +1,26 @@
		package co.dapi.types;

		public class PullTransfer {


		import java.util.Optional;

		public class GetPullResponse extends BaseResponse {

Conversation

kc-sabal commented Jan 12, 2023

Uh oh!

jonmmyers left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants