feat: download attestation.proto for durabletask-client#1738
Open
javier-aliaga wants to merge 2 commits intodapr:masterfrom
Open
feat: download attestation.proto for durabletask-client#1738javier-aliaga wants to merge 2 commits intodapr:masterfrom
javier-aliaga wants to merge 2 commits intodapr:masterfrom
Conversation
Add attestation.proto to the list of proto files fetched by the download-maven-plugin so it is compiled alongside the other durabletask protos. Signed-off-by: Javier Aliaga <javier@diagrid.io>
5575dcc to
bc660b5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1738 +/- ##
=========================================
Coverage 76.76% 76.76%
Complexity 2260 2260
=========================================
Files 241 241
Lines 7066 7066
Branches 740 740
=========================================
Hits 5424 5424
Misses 1279 1279
Partials 363 363 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Javier Aliaga <javier@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add attestation.proto to the list of proto files fetched by the download-maven-plugin so it is compiled alongside the other durabletask protos.
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: