Acquire RLock after readyCh in GetX509SVID and FetchJWTSVID#147
Merged
Acquire RLock after readyCh in GetX509SVID and FetchJWTSVID#147
Conversation
Signed-off-by: Albert Callarisa <albert@diagrid.io>
acroca
force-pushed
the
spiffe-lock-after-ready
branch
from
8a49e01 to
db0d24b
Compare
JoshVanL
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetX509SVIDandFetchJWTSVIDwere acquiring the read lock before blocking onreadyCh. The lock protects the SVID fields; acquiring it before those fields are even populated is incorrect ordering.Also ,adds unit tests for
GetX509SVID