Skip to content

Conversation

@sicoyle
Copy link
Contributor

@sicoyle sicoyle commented Jan 29, 2026

Description

Corresponding PR for dapr/durabletask-python#42

I identified a race condition where we report success from wf_client.start() in the Python SDK before the DurableTask worker’s stream reader thread is fully initialized. This PR addresses the issue by introducing a poll to check for the worker and its stream reader thread have actually started so it can actually signal everything is ready and the wf client start was fully successful. This will ensure that workflows scheduled immediately do not hit issues due to the stream reader not being ready yet. I also added more try/except blocks and additional logging.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Samantha Coyle <sam@diagrid.io>
@sicoyle sicoyle requested review from a team as code owners January 29, 2026 22:57
Signed-off-by: Samantha Coyle <sam@diagrid.io>
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 87.80488% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.67%. Comparing base (bffb749) to head (810b53c).
⚠️ Report is 65 commits behind head on main.

Files with missing lines Patch % Lines
...ext-workflow/dapr/ext/workflow/workflow_runtime.py 64.28% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
+ Coverage   86.63%   86.67%   +0.04%     
==========================================
  Files          84      103      +19     
  Lines        4473     7093    +2620     
==========================================
+ Hits         3875     6148    +2273     
- Misses        598      945     +347     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants