Add Teredo (RFC4380) embedding strategy#109
Conversation
Greptile SummaryThis PR adds a new
Confidence Score: 4/5Safe to merge; the implementation is correct and the XOR obfuscation follows RFC 4380 §4 exactly. The Teredo strategy, test vectors (including the well-known RFC 4380 example), and Multi integration test are all correct. The only notable issue is a prose inconsistency in the documentation — the sentence still says "main three" after a fourth strategy was added to the table, and the deprecated strategy is not named. No production logic or test correctness is affected. docs/05-strategies.md — the strategy-count and deprecation wording should be updated to match the four-entry table. Important Files Changed
Reviews (1): Last reviewed commit: "feature(strategy): ✨ add Teredo (RFC4380..." | Re-trigger Greptile |
| Unfortunately there are several different strategies for embedding a version 4 | ||
| address into version 6, so this library offers various strategy implementations | ||
| for the main three: | ||
| for the main three (and one deprecated): |
There was a problem hiding this comment.
The prose says "the main three (and one deprecated)" but the table now has four entries. The parenthetical also never identifies which strategy is deprecated (IPv4-compatible, per RFC 4291 §2.5.5.1). Consider updating the sentence to count accurately and name the deprecated strategy.
| for the main three (and one deprecated): | |
| for four strategies (the IPv4-compatible strategy is deprecated per RFC 4291): |
No description provided.