feat(swift-sdk): add ZK shielded sync status UI#3393
Draft
QuantumExplorer wants to merge 10 commits intov3.1-devfrom
Draft
feat(swift-sdk): add ZK shielded sync status UI#3393QuantumExplorer wants to merge 10 commits intov3.1-devfrom
QuantumExplorer wants to merge 10 commits intov3.1-devfrom
Conversation
…d nullifier sync - Create ZKSyncService with periodic sync loop (30s interval) - Display shielded balance, orchard address, note/nullifier stats in CoreContentView - Persist balance and address across app launches via UserDefaults - Wire into UnifiedAppState lifecycle and pull-to-refresh Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ations Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Use TrustedHttpContextProvider::new_with_url for local/regtest networks, connecting to quorum sidecar at localhost:22444 (dashmate Docker default) - Replace separate "Use Local DAPI" and "Use Local Core" toggles with unified "Use Docker Setup" toggle - Default DAPI address changed to https://127.0.0.1:2443 (envoy gateway) - Persist selected tab across app launches - SDK.init uses dash_sdk_create_trusted for all networks (Rust auto-detects local) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… account types - Restore AddAccountView from feat/platformSync branch for adding accounts to wallets - Add platformPayment, dashPayReceivingFunds, dashPayExternalAccount to AccountCategory and AccountType - Use wallet_add_platform_payment_account() for Platform Payment accounts (requires key_class) - Add CoreWalletManager.addAccount() public method - Add regtest (case 2) to SPV client network config instead of falling through to testnet - Default local Core P2P peer to 127.0.0.1:20001 (Docker dashmate port) - Add Local/Regtest option to wallet creation network picker Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ounts - Change default local DAPI from https to http (Docker envoy self-signed cert rejected) - Enumerate platform payment accounts in getAccounts() for wallet detail view Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add "Get 10 DASH from Faucet" button on Receive screen (Core tab, Docker mode only) - Calls seed node Core RPC sendtoaddress at 127.0.0.1:20302 - Add Faucet RPC Password field in Settings when Docker Setup is enabled - Password persisted in UserDefaults for subsequent faucet requests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove key-wallet-manager workspace dependency (merged into key-wallet) - Update rs-dpp and rs-platform-wallet to use key-wallet directly - Remove dashcore "std" feature (removed upstream) - Update WalletTransactionChecker for new check_core_transaction signature (added &mut Wallet and is_from_mempool params) - Add mark_instant_send_utxos to WalletInfoInterface impl Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Adds a ZK Shielded Sync status section to the iOS SwiftExampleApp, mirroring the existing Platform Address Sync section. This provides real-time visibility into shielded pool synchronization (note discovery + nullifier checking).
What was done?
ZKSyncService — New
@MainActor ObservableObjectservice that orchestrates periodic ZK sync:syncNotes()thensyncNullifiers()onShieldedPoolClientevery 30 secondszkSync_{network}_*)UnifiedAppState — Wired ZK sync into app lifecycle:
CoreContentView — New "ZK Shielded Sync" UI section showing:
Environment injection and pull-to-refresh integration
How Has This Been Tested?
xcodebuild -sdk iphonesimulator)Breaking Changes
None
Checklist:
🤖 Generated with Claude Code