hist(group): add validation & empty-data handling; docstring, guide and tests#658
Open
Subat-01 wants to merge 1 commit intodata-8:masterfrom
Open
hist(group): add validation & empty-data handling; docstring, guide and tests#658Subat-01 wants to merge 1 commit intodata-8:masterfrom
Subat-01 wants to merge 1 commit intodata-8:masterfrom
Conversation
…and empty-group handling; add tests; fix folium tile attribution and BeautifyIcon textColor compatibility
Subat-01
changed the title
davidwagner
reviewed
Jan 12, 2026
| Constraints and behavior: | ||
| - ``group`` cannot be combined with ``bin_column``. | ||
| - ``group`` requires exactly one histogram value column. If more | ||
| than one value column is passed, a ``ValueError`` is raised. |
Member
There was a problem hiding this comment.
No need to specify which exception is raised if a constraint is violated.
davidwagner
reviewed
Jan 12, 2026
| - ``group`` cannot be combined with ``bin_column``. | ||
| - ``group`` requires exactly one histogram value column. If more | ||
| than one value column is passed, a ``ValueError`` is raised. | ||
| - If ``group`` does not reference an existing column (by label or |
davidwagner
reviewed
Jan 12, 2026
| warnings.warn("It looks like you're making a grouped histogram with " | ||
| "a lot of groups ({:d}), which is probably incorrect." | ||
| .format(grouped.num_rows)) | ||
| if grouped.num_rows == 0: |
Member
There was a problem hiding this comment.
What is the argument for this change in behavior?
davidwagner
reviewed
Jan 12, 2026
| # This code is factored as a function for clarity only. | ||
| n = len(values_dict) | ||
| if n == 0: | ||
| # Create an empty figure to maintain a no-error contract on empty groups |
Member
There was a problem hiding this comment.
What is the argument for this change in behavior? Why is it important to avoid exceptions in this case?
davidwagner
reviewed
Jan 12, 2026
|
|
||
| Notes and constraints: | ||
| - `group` cannot be used together with `bin_column`. | ||
| - `group` expects exactly one numeric value column (e.g., `'height'`). Passing multiple value columns raises a `ValueError`. |
Member
There was a problem hiding this comment.
I don't think the exception raised should be part of the API specification.
davidwagner
reviewed
Jan 12, 2026
| Notes and constraints: | ||
| - `group` cannot be used together with `bin_column`. | ||
| - `group` expects exactly one numeric value column (e.g., `'height'`). Passing multiple value columns raises a `ValueError`. | ||
| - If `group` does not reference an existing column label or index, a `ValueError` is raised. |
Member
There was a problem hiding this comment.
I don't think the exception raised should be part of the API specification.
davidwagner
reviewed
Jan 12, 2026
| - `group` cannot be used together with `bin_column`. | ||
| - `group` expects exactly one numeric value column (e.g., `'height'`). Passing multiple value columns raises a `ValueError`. | ||
| - If `group` does not reference an existing column label or index, a `ValueError` is raised. | ||
| - If the data are empty for all groups, `hist` creates an empty figure and returns without error. |
Member
|
Thanks for these improvements! I prefer that each pull request address one self-contained issue. Please split out the fixes to maps/tiles in a separate PR. I do prefer that we stick to .rst. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Table.histneeded clearer documentation and safer behavior for thegroupargument.Changes
Code
datascience/tables.py:histgroupis a legal column (label or index); otherwise raiseValueErrorwith a clear message.groupcannot be used withbin_column; and grouping allows only one numeric data column.t.hist('height', group='gender')t.hist('height', group='gender', side_by_side=True)Docs
docs/hist_grouping.md:.rstand add it to the TOC.)Tests
tests/test_hist_group.pyValueError.(Optional) Maps small fixes
datascience/maps.pyattrsupplied (Folium >= 0.20).text_color->textColoroption forBeautifyIconfor backward compatibility.Verification
Files changed (for quick review)
datascience/tables.py[around lines ~5310, ~5398, ~5420, ~5455]docs/hist_grouping.mdtests/test_hist_group.pydatascience/maps.pyCompatibility & Notes