ENH: add angle#718
Conversation
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
|
Looks great, thanks for jumping on this issue! |
|
FYI your codecov was probably failing because you're not covering all the cases in your tests. But I think if you add the tests I gave to the ones you wrote, it should work. |
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
|
@NeilGirdhar Thanks for the suggestions! I've added them. I've also changed the function signature a bit to remove positional-only arguments for z and deg, as I feel this is much closer to the np implementation. |
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
|
Thanks for the quick PR and changes @prady0t Looks good to me! (@lucascolley ) |
lucascolley
left a comment
lucascolley
left a comment
There was a problem hiding this comment.
Thanks both!
One more task on top of the inline comments: add angle to docs/api-reference.md.
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
| setdiff1d | ||
| sinc | ||
| union1d | ||
| angle |
There was a problem hiding this comment.
could this be moved to keep the list in alphabetical order? i.e. at the top
| array | ||
| The counterclockwise angle from the positive real axis on the complex | ||
| plane in the range ``(-pi, pi]``. | ||
|
|
There was a problem hiding this comment.
can we add a note to the documentation stating what happens if the input x is real? i.e. interpreted as x + 0j
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
3 participants
Fixes #714