Enhance error handling in DelegatingMultiSinkOutputCommitter#1606
Open
Enhance error handling in DelegatingMultiSinkOutputCommitter#1606
Conversation
…g logging for task and job commit failures
| } catch (IOException e) { | ||
| LOG.warn("BigQuery multi-sink table '{}' failed during job commit. Reason: {}", | ||
| tableName, getFailureReason(e), e); | ||
| throw e; |
Contributor
There was a problem hiding this comment.
logging and re-throwing an error is considered an anti-pattern.
Isn't this error propagated upwards and logged somewhere in pipeline run?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves error handling and logging in the
DelegatingMultiSinkOutputCommitterclass for BigQuery multi-sink operations. The main focus is to provide more informative log messages when task or job commits fail, making it easier to diagnose issues.Enhanced error handling and logging:
Loggerinstance (LOG) using SLF4J to theDelegatingMultiSinkOutputCommitterclass for logging warnings. [1] [2]commitTaskandcommitJobcalls in try-catch blocks to log warnings with detailed failure reasons when anIOExceptionoccurs, then re-throw the exception.getFailureReasonhelper method to extract the root cause message from anIOExceptionfor clearer log output.