chore(ci): apply settings before role validation in session restore#19358
Merged
TCeason merged 2 commits intodatabendlabs:mainfrom Feb 5, 2026
Merged
chore(ci): apply settings before role validation in session restore#19358TCeason merged 2 commits intodatabendlabs:mainfrom
TCeason merged 2 commits intodatabendlabs:mainfrom
Conversation
youngsofun
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
The HTTP handler restores session state in
HttpSessionConf::restore().Previously, settings (including
sandbox_tenant) were applied afterrole validation, causing role checks to fail when using sandbox tenant
in sqllogic tests.
This fix reorders the restore sequence to apply settings first, ensuring
sandbox_tenanttakes effect before role validation occurs.Also removes an obsolete TODO comment about secondary roles.
Tests
Type of change
This change is