Skip to content

chore(ci): apply settings before role validation in session restore#19358

Merged
TCeason merged 2 commits intodatabendlabs:mainfrom
TCeason:http_restore
Feb 5, 2026
Merged

chore(ci): apply settings before role validation in session restore#19358
TCeason merged 2 commits intodatabendlabs:mainfrom
TCeason:http_restore

Conversation

@TCeason
Copy link
Copy Markdown
Collaborator

@TCeason TCeason commented Jan 29, 2026

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

The HTTP handler restores session state in HttpSessionConf::restore().
Previously, settings (including sandbox_tenant) were applied after
role validation, causing role checks to fail when using sandbox tenant
in sqllogic tests.

This fix reorders the restore sequence to apply settings first, ensuring
sandbox_tenant takes effect before role validation occurs.

Also removes an obsolete TODO comment about secondary roles.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions Bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 29, 2026
@TCeason TCeason changed the title chore(ci): remove some onlyif mysql chore(ci): apply settings before role validation in session restore Jan 29, 2026
@TCeason TCeason merged commit cbb3e32 into databendlabs:main Feb 5, 2026
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-chore this PR only has small changes that no need to record, like coding styles.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants