Skip to content

Fix bundle generate job to preserve nested notebook directory structure#4596

Open
varundeepsaini wants to merge 1 commit intodatabricks:mainfrom
varundeepsaini:fix/bundle-generate-job
Open

Fix bundle generate job to preserve nested notebook directory structure#4596
varundeepsaini wants to merge 1 commit intodatabricks:mainfrom
varundeepsaini:fix/bundle-generate-job

Conversation

@varundeepsaini
Copy link
Contributor

Changes

Fixes #4503.

Add MarkTasksForDownload that computes a common base path across all notebook tasks before downloading, replacing the per-task loop in job.go. This preserves nested directory structure instead of flattening all notebooks into src/.

Tests

  • Unit tests for commonDirPrefix and MarkTasksForDownload.
  • Acceptance test bundle/generate/job_nested_notebooks reproducing the issue.
  • No regressions in existing python_job, ipynb_job, git_job tests.

Test are written by Claude Code

Signed-off-by: Varun Deep Saini <varun.23bcs10048@ms.sst.scaler.com>
@github-actions
Copy link

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 4596
  • Commit SHA: dc572e1f4db03136d474c4e0a77f14496a318056

Checks will be approved automatically on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

databricks bundle generate job --existing-job-id flattens notebook directory structure

1 participant