acc: run volume_doesnot_exist locally; fix testserver schema predictive-optimization flag#5697
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: ffc03a5
21 interesting tests: 13 SKIP, 7 KNOWN, 1 RECOVERED
Top 6 slowest tests (at least 2 minutes):
|
radakam
changed the title
radakam
force-pushed
the
deco-27488-acc-volume-doesnot-exist-local
branch
from
4f16bb3 to
4755dfc
Compare
radakam
force-pushed
the
deco-27488-acc-volume-doesnot-exist-local
branch
from
4755dfc to
334bdcb
Compare
denik
approved these changes
Jun 24, 2026
…ally Enable the volume_doesnot_exist acceptance test to run against the local testserver in addition to cloud. The testserver already models UC schema and volume CRUD (including a 404 on a missing volume), so the test passes end-to-end locally: bundle deploy fails with the expected "volume ... does not exist" error. The only divergence is the effective predictive optimization value, which is inherited from the metastore (DISABLE on the test metastore vs ENABLE on the testserver). A test-scoped Repls normalizes it so a single golden stays valid for both local and cloud runs. Part of DECO-27488.
Replace the test-scoped Repls in volume_doesnot_exist with a fix to the
testserver itself: the fake schema-create response now inherits DISABLE
from the metastore, matching the real test metastore. Local and cloud
then produce identical output, so the single golden is valid for both
without masking the value.
Regenerate the schema goldens that previously baked in the testserver's
ENABLE value (schemas/recreate, grants/schemas/{out_of_band_principal,
duplicate_principals}).
Part of DECO-27488.
…on flag The testserver fake now inherits DISABLE for effective_predictive_optimization_flag.value, so the dresources schema unit test that exercises the same SchemasCreate path must expect DISABLE.
radakam
force-pushed
the
deco-27488-acc-volume-doesnot-exist-local
branch
from
99e15aa to
ffc03a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Run
acceptance/bundle/artifacts/artifact_path_with_volume/volume_doesnot_existlocally as well as on cloud (Local = true).To make local output match cloud, fix the testserver instead of papering over the diff:
libs/testserver/schemas.gonow returnsDISABLE(wasENABLE) foreffective_predictive_optimization_flag.value, matching the real test metastore the fake already pins to. Regenerated the goldens that baked in the oldENABLE:acceptance/bundle/resources/schemas/recreate/output.txtacceptance/bundle/resources/grants/schemas/out_of_band_principal/{out.plan.direct.json,out.plan2.direct.json}acceptance/bundle/resources/grants/schemas/duplicate_principals/out.plan.direct.jsonbundle/direct/dresources/schema_test.go(unit test hitting the same fake)Why
Part of converting
Local = falseacceptance tests to local+cloud. The only divergence was the metastore-inherited optimization flag (DISABLEon the real metastore,ENABLEon the fake). It's a fixed value, not per-run, so the faithful fix is to make the fake return what the real API returns. This keeps one golden valid for both local and cloud and improves testserver fidelity for every schema test. Same approach as #5689. The cloud-only siblingvolume_not_deployedalready recordsDISABLE, corroborating the real value.Tests
go test ./acceptance -run 'TestAccept/bundle/(artifacts/artifact_path_with_volume|resources/grants/schemas|resources/schemas)'andgo test ./bundle/direct/dresourcespass locally (terraform + direct)../task fmt,./task checks,./task lintclean.